Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Display extension's shell icon in the documents' tabs #12231

Open
Yaron10 opened this issue Sep 24, 2022 · 8 comments
Open

Comments

@Yaron10
Copy link

Yaron10 commented Sep 24, 2022

Many editors display the extension's shell icon in the documents' tabs.
I find it very helpful, and I think it would be a major addition to Notepad++.

If the idea is accepted, the desired implementation/result can be discussed.
There are quite a few options. The following might be a bit unconventional, but it has some advantages.

In a normal state, replace the Close button with the extension's shell icon.
On hovering and pushing, display the Close button.
(The Close button would need to be changed to 16x16).


Notepad++ 8.4.6.

@Yaron10
Copy link
Author

Yaron10 commented Oct 17, 2022

Beautifully implemented in MenuIcons v2 by @francostellari.
https://github.com/francostellari/NppPlugins/tree/main/MenuIcons.

Thank you Franco. 👍

@alankilborn
Copy link
Contributor

Beautifully implemented in MenuIcons v2 by @francostellari.

I agree!

@Yaron10 Might as well close this issue now?

@Yaron10
Copy link
Author

Yaron10 commented Oct 19, 2022

@alankilborn,

@francostellari did a great job.
But he might still submit a PR integrating this feature in NPP code.
We could have more customizable options then.

@dbareis
Copy link

dbareis commented Oct 28, 2022

MenuIcons is great but I wish it added a tint or something to make it more obvious that the file needs saving, having a SINGLE character prefix (which doesn't always display either) is not enough.

@alankilborn
Copy link
Contributor

MenuIcons is great but I wish it added a tint or something to make it more obvious that the file needs saving, having a SINGLE character prefix (which doesn't always display either) is not enough.

Obviously you'd make such a request for that HERE, right?

make it more obvious that the file needs saving

And the default way that Notepad++ itself does this is way better than looking at a bunch of (IMO) not-that-important shell icon shapes, but YMMV.

@francostellari
Copy link

francostellari commented Oct 28, 2022 via email

@francostellari
Copy link

francostellari commented Oct 28, 2022 via email

@dbareis
Copy link

dbareis commented Oct 29, 2022

I have reported the MenuIcons bugs here:

I don't know where the idea came from that I didn't want the shell icons as that is the only reason I installed MenuIcons in the first place...

Is the source code available so I can fork (or merge it) it if required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants