Incorrect display of Cyrillic in the macros submenu

[rddim]

Description of the Issue

When I use Cyrillic in the macros submenu it appears unreadable in the Macro menu.

Steps to Reproduce the Issue

1. Download the latest v8.4.8 RC2 npp.8.4.8.portable.minimalist.x64.7z from http://download.notepad-plus-plus.org/repository/8.x/8.4.8.RC2/
2. Open the shortcuts.xml
3. Follow the instructions in the file and add макрос for the submenu (i.e. FolderName="макрос") to the existing Trim Trailing Space and Save macro
4. Save and close the file
5. Open notepad++.exe and click on Macro menu

Expected Behavior

Actual Behavior

Debug Information

Notepad++ v8.4.8   (64-bit)
Build time : Dec 19 2022 - 02:31:02
Path : X:\xxx\npp.8.4.8.portable.minimalist.x64\notepad++.exe
Command Line : 
Admin mode : ON
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 7 Professional (64-bit) 
OS Build : 7601.0
Current ANSI codepage : 1251
Plugins : none

[rdipardo]

The bug is in the TinyXML library. It parses files with fgetws() (a.k.a. generic_fgets) ¹, which does not properly decode multi-byte text.

An explicit encoding declaration at the top of shortcuts.xml does not seem to make any difference ².

Footnotes

1. https://github.com/notepad-plus-plus/notepad-plus-plus/blob/58416114da14536dcc7a8ad36010da3382366ba6/PowerEditor/src/TinyXml/tinyxml.cpp#L761-L764 ↩

2. i.e., <?xml version="1.0" encoding="UTF-8"?> ↩

[ozone10]

Hmm TinyXML is not being developed anymore.

Maybe Notepad++ should try to move to TinyXML2, but this will require major refactoring.