Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Replace by" wording in Tab Settings #13186

Closed
alankilborn opened this issue Feb 21, 2023 · 9 comments
Closed

Change "Replace by" wording in Tab Settings #13186

alankilborn opened this issue Feb 21, 2023 · 9 comments
Labels
reject translation Issues or PRs related to translation of N++ UI

Comments

@alankilborn
Copy link
Contributor

alankilborn commented Feb 21, 2023

Description of the Issue

It is possible for a user to misinterpret the meaning of the Replace by space control on Settings (menu) > Preferences... > Language > Tab Settings.

The use of "replace by" could be interpreted to mean that, when the box is transitioned from unchecked to checked by the user, a replace (in the sense of Search (menu) > Replace... > Replace All) will be executed for the current document.

Ref.: #13182

Suggestions for change:

  • Replace by space --> "Tab press inserts space(s)"
  • Replace by space --> "Tab key inserts space(s)"

Debug Information

Above comment made on behavior current to N++ v. 8.4.9.

Screenshot

image

@ArkadiuszMichalski ArkadiuszMichalski added the translation Issues or PRs related to translation of N++ UI label Feb 21, 2023
@ArkadiuszMichalski
Copy link
Contributor

ArkadiuszMichalski commented Feb 21, 2023

For me the current form is clear. Well, but if there is space and the new description will be more precise, it may be worth changing.

@alankilborn
Copy link
Contributor Author

alankilborn commented Feb 21, 2023

@ArkadiuszMichalski

Why did you tag this with a "translation" label?
It isn't a translation issue.
If it is accepted and implemented then the code and english.xml will be changed.
Only AFTER that point does it becomes a translation issue.
Or do I misunderstand the usage of the "translation" label?

For me the current form is clear.

Apparently it is not clear for all users. Sure it is impossible to satisfy everyone, but sometimes it is best to reflect and think: "Could this be improved and is it worth it to do so?" In this case, my opinion is yes.

@pryrt
Copy link
Contributor

pryrt commented Feb 21, 2023

I would vote for "Tab key inserts space(s)".

(And I am not offended by the "translation" label, because changing this will affect translation: looking at the other issues that have that tag, it seems to be both submissions for translation, and changes that will create a need for translations to be updated; since this is changing the English phrasing, it creates a need for the translators to assess whether there is the same translation need in other languages, or whether their existing phrasing already leaves no ambiguity.)

@alankilborn
Copy link
Contributor Author

And I am not offended by the "translation" label

Well, "offended" would not describe my reaction either. :-)
But my conception of the "translation" label is that it cues translators that something needs translating (maybe I'm wrong?). As nothing has been changed (yet) on this, why cue them?
It perhaps also makes devs gloss over an issue with such a label ("...purely a translation issue...").

@ArkadiuszMichalski
Copy link
Contributor

But my conception of the "translation" label is that it cues translators that something needs translating (maybe I'm wrong?).

Not so strictly, also if we are discussing the choice of a better name. Here we basically do not modify the mechanism of the action, only its name, so marking it with this label makes sense. In addition, it is easier to search for such issues marked with a common label. After some time such issues are pushed down by newer ones and then they are harder to find. Thanks to this label with one click we get a list of open problems and we can choose which one is worth (or we can) fix.

@LexaGV
Copy link

LexaGV commented Feb 22, 2023

+1000000 for "Tab key inserts space(s)" - THIS is real action which happen underneath! Only pressing key makes spaces, existing 0x09 stay at place.

@sXNA
Copy link

sXNA commented Feb 22, 2023

maybe fix can be included in this #13177

@alankilborn
Copy link
Contributor Author

maybe fix can be included in this

It could, but it is also fine for it to be two separate things, especially as that is the track it is currently on.

@donho
Copy link
Member

donho commented Mar 14, 2023

I don't want to change it for 2 reasons:

  1. I want to make it as short as possible so all the translation could fit in it.
  2. Under "Tab settings" with option Replace by space means "Replace Tab by space" and that is obvious to me.

If current label makes other users confusing, and complains keep coming, I'll consider changing it. But for the moment, I prefer to keep the current one.

@donho donho closed this as completed Mar 14, 2023
@donho donho added the reject label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reject translation Issues or PRs related to translation of N++ UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants