Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no folding for the assembly language - Next Round #13758

Closed
UnlimitedChild opened this issue Jun 9, 2023 · 0 comments
Closed

There is no folding for the assembly language - Next Round #13758

UnlimitedChild opened this issue Jun 9, 2023 · 0 comments

Comments

@UnlimitedChild
Copy link

#9888

Sorry, assembly language is not standardized like C++. Aside from that, folding is a Scintilla feature not a Notepad++ feature (any folding changes would have to come from that project).

Can't be considered for N++ implementation unless/until Scintilla changes

folding is implemented for the asm lexer
ScintillaOrg/lexilla#123

This feature has been implemented, but is still not available in the editor.
@rdipardo rdipardo mentioned this issue Jun 10, 2023
Closed
@donho donho closed this as completed in fadc083 Jun 11, 2023
molsonkiko pushed a commit to molsonkiko/notepad-plus-plus that referenced this issue Jun 13, 2023
@rdipardo @molsonkiko
Enable code folding in Assembly source files
b4127de 
Enables the folding capabilities of Lexilla's Assembly lexer by:

 - adding the currently [unused keyword groups], `Directives4Foldstart` and `Directives4Foldend`;

https://github.com/notepad-plus-plus/notepad-plus-plus/blob/b5e2e9d737c88bf13ddb956662476f7298d89ce9/lexilla/lexers/LexAsm.cxx#L101-L109

 - adding some fold-trigger keywords to the new `Directives4Foldstart` and `Directives4Foldend` groups, and *duplicating* them in the existing `Directives` group, following [these instructions].

 - activating a *selection* of the lexer's [optional folding properties]. Since `fold.asm.comment.explicit` is not likely to be popular, the default delimiters `;{` and `;}` are permanent, and `fold.asm.explicit.anywhere` is *not* turned on. Users who want different options can always use [Python Script] to set them dynamically.

There are plenty of *more* candidate keywords than what I've added, but I'm not very familiar with [Microsoft's macro assembler].

Fix notepad-plus-plus#13758, fix notepad-plus-plus#9888, close notepad-plus-plus#13762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable code folding in assembly source files
1 participant
@UnlimitedChild