New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find Dialog: display "(Filtered!)" in the status bar #14307
Comments
How about adding |
@Yaron10 OTOH, (almost) all the false alerts with such bug report are due to unchecked Wrap around. I think it's enough that we give extra warning Find: "Can't find the text xxx: turn ON Wrap around maybe?" only in case that Wrap around is not checked. What do you think? |
"whole word" is also often a problem. |
Implemented in #14347 |
"Wrap around" has been a checkbox in Windows' notepad.exe Find window for over 30 years -- users should know how it works by now. It provides no additional help to the user that is too dumb to learn how to use it. Just saying that no software can help the truly dumb. |
@alankilborn Could you provide the concerning issues please? |
I mean, support is often needed because "find is broken" because it won't find a user's match, and user has previously (from some earlier search) checkmarked Match whole word only. So maybe they are searching for |
Thank you for #14347. 👍 It's true that "Wrap around" is the main cause of confusion.
|
IMO the problem posed by opening this issue can't be solved. |
I don't expect it to solve ALL the confusions/issues. It should probably help in some cases. |
If Don decides to go ahead with the extra message.
That means displaying |
Something like The best solution might be a Community FAQ that users that post (or create an issue) of the "find is broken" variety are pointed to. But...as you will. |
Personally I'd like to have it. But I see your point. If we put Case & Word aside, the following approach might be another option:
It IS somewhat related. |
?? |
Well, if PEBCAK read FAQ, they won't be PEBCAK. BTW, I prefer to use PEBCAK instead of "dumb" :) |
Just updated PR #14347: |
The tooltip is nice and clever! Certainly better than
Find what: Hello. Let's try the commands that are affected by "Wrap around" and display info in the status bar. Find next: Can't find the text "Hello"; red color; beep; flash; tooltip. I understand the beep and flash on "Find next" as it can be used when the Find dialog is closed.
I still don't understand it. :) |
But, with the exception of FAiCD, you DO understand how Wrap around affects every other search command (that operates on a single file), correct? |
The tooltip is a fabulous presentation for this issue's problem! Minor issue: Users don't tend to know that you have to hover over the little speech balloon in order to see the tip. I don't know what could possibly solve that for the |
I do understand that. :) |
Related, try this from the Replace tab:
Press Press Similar for Find in Files; this expression will result in nothing on the Find dialog status bar and will put the following into Search results window: Etc. for other types of search commands... |
Sometimes even a rope can be pushed? :-) |
I hardly use RegEx.
And this belongs to #14306, doesn't it? :) |
Exact STR were given, in #14307 (comment) , starting from "try this from the Replace tab"; nothing is missing as far as I see.
Not really. 14306 deals with a way to see what parameters a search was run with, not an "invalid regex" speech bubble, or inconsistencies... My point here was that if you're going to have a speech bubble for error/warning messages, it should be consistent whenever such a bogus find is initiated. Which I thought was the point you were making with your "let's try the commands..." here: #14307 (comment) and the "other inconsistencies". However, my regex inconsistency is at lease 51% off-topic and maybe more :-) so it probably deserves its own issue (but if memory [which is getting worse every day] serves, there already IS such an issue that is open). |
I agree. |
You want exact STR for that part of it? The Find in Files that writes into Search results? Oh, maybe I see now that you don't get what I got... you do get the Invalid Regular Expression message, for Replace? OK, I'll have to check my result again when I get back to my PC. |
@Yaron10 I must offer grave apologies. I do get the "Invalid Regular Expression" message when I initiate any type of search. At least today I do. Yesterday, when I was trying it, I didn't always get it, but I have no explanation as to why. Yesterday when I tried with Find All... it would proceed to the search step, because I copied But... let's definitely call this too far off-topic. As long as the new tooltip (from this issue) appears at appropriate times, I'd say things are good. |
No need to apologize. :) If we concentrate only on "Wrap around" in "Find Next/Prev"...
|
@Yaron10 @alankilborn I'm really glad that you like my solution - that changes a little bit the situation that we disagree with each others :)
I was guessing what it is FAiCD meaning, and found it in on Internet :)
:D
Added into PR #14347 as well. |
I get really tired of typing Find All in Current Document constantly, thus "FAiCD" or sometimes the simpler "FACD". :-)
Oh, no...we don't want users to stop using the product! (I know you were just joking) A real user that was having trouble with "regex complexity error" had no idea to hover on that speech icon. He showed a screenshot of the Find window he was using, and I told him to hover on the speech icon and get the balloon tip popup speech bubble. He said "Ah...I HAD clicked on that and nothing happened -- I had no idea that you had to hover to see it!".
Hmm, would it be possible to shorten the hover time needed for the balloon tip to appear (admittedly, it is already short...but not instant), OR make it so if the speech icon is actually clicked, the hover tip appears? |
It's a "nicety" (to be very explicit) but indeed it is a problem when it is very long! |
In other commands you display |
I thought the complaint was relating to very long text, but it was something else. :-( On the subject of very long text, how about dropping the quoting of the search term entirely? That is, go with a generic "search term not found"... |
Yes, the "complaint" was that you might not see the scope and tooltip.
Or |
Yes, |
True! It'll be fixed.
There must be a reason, but just I don't remember :)
The scope is displayed generally in the search failed case. I appreciate you guys' effort concerning the inconsistency in the application. |
Hi, I'm new to the community - I know this issue is closed but can I still comment here? Will anybody see it? If I should post it somewhere else please direct me - Thanks. I've been employed as a programmer since 1985 but my whole attitude to PEBKAC changed when I read "About Face" by Alan Cooper (the guy who invented Visual Basic) in 1997. His mantra is that the programmer's job is to enable the user to achieve their goal in as unobtrusive a manner as possible. And with no disrespect to anybody here, he says deeming anything insurmountable because the user is too dumb is just a factor of how much effort you're willing to put in. Every one of the chosen options can be described in the status bar, e.g.
Quite clearly any or all of these can be combined based on the options chosen, e.g.
This only leaves the issue of a very long search term. IMO the search term is the least important information in the message and may be trimmed if necessary with the very familiar ellipsis, e.g.
As is common, hovering over a trimmed search term could overlay a tooltip with the untrimmed search term included. |
Welcome.
Yes.
Anyone involved in the prior conversation, or anyone subscribed to all activity, indeed will see it. Thanks for your thoughts. In general, I feel that if I see Contrast this with #14306 where, because options are no longer present, it is impossible to know what options were in effect at the time the search was conducted. |
Quite often users are bewildered after executing a search and seeing the result(s).
A recent example.
Suggestion:
Display the range & conditions in the Find Dialog status bar.
Notepad++ v8.5.8.
The text was updated successfully, but these errors were encountered: