Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting PowerToys Keyboard Manager key remaps #14470

Closed
ndc opened this issue Dec 11, 2023 · 8 comments · Fixed by notepad-plus-plus/npp-usermanual#614
Closed

Detecting PowerToys Keyboard Manager key remaps #14470

ndc opened this issue Dec 11, 2023 · 8 comments · Fixed by notepad-plus-plus/npp-usermanual#614
Assignees

Comments

@ndc
Copy link

ndc commented Dec 11, 2023

PowerToys Keyboard Manager is a tool to remap keys in a keyboard. I use this tool to remap my laptop keys because I use 'home' and 'end' keys much more frequently than 'insert' and 'delete'. Notepad++ used to be able to detect the key remapping but the latest version doesn't. The 'insert' and 'delete' buttons become 'insert' and 'delete', ignoring the remap.

Steps to Reproduce the Issue

  1. Install PowerToys.
  2. Using Keyboard Manager remap 'insert' to 'home', 'delete' to 'end'.
  3. Press 'insert' and 'delete'

Expected Behavior

The cursor goes to the beginning of the line then to the end of the line.

Actual Behavior

Edit mode changes to overwrite and then deletes the character under the cursor.

Debug Information

Notepad++ v8.6 (64-bit)
Build time : Nov 23 2023 - 16:58:44
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line : "C:\mysolutions\mysolution.sln"
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 11 Enterprise (64-bit)
OS Version : 22H2
OS Build : 22621.2715
Current ANSI codepage : 1252
Plugins :
mimeTools (2.9)
NppConverter (4.5)
NppExport (0.4)

@alankilborn
Copy link
Contributor

Probably an effect from the implementation from #14296

@donho
Copy link
Member

donho commented Dec 11, 2023

@ndc
Could you reproduce it in v8.5.8 ?

@ndc
Copy link
Author

ndc commented Dec 12, 2023

@donho not reproducible in 8.5.8. My remaps still work in 8.5.8.

@donho donho self-assigned this Dec 12, 2023
@ndc
Copy link
Author

ndc commented Dec 12, 2023

BTW congrats on the 20th anniversary of notepad++! 👍

@donho
Copy link
Member

donho commented Dec 13, 2023

@ndc
Do you use Shift-DEL? Is the Shift-DEL doesn't work for your assigned action?
Or you use DEL alone while the multi-edit being active?

@ndc
Copy link
Author

ndc commented Dec 13, 2023

@donho actually both used to work, the behavior is just like pressing END and SHIFT-END (the key that I assign to DEL).
For example pressing DEL will go to the end of the line, while pressing SHIFT-DEL will select the characters between the current cursor location to the end of the line.

@donho
Copy link
Member

donho commented Dec 13, 2023

@ndc
Thank you for your reply.
I just want to know if Shift-DEL doesn't work but DEL works for you in v8.6.
Also, when you use Shift-DEL, what does it happens?

donho added a commit to donho/notepad-plus-plus that referenced this issue Dec 13, 2023
In order to disable the hard-coded shortcut "Shift-DEL" ability (new feature introduced in v8.6) which delete current line while no selection, users must add an empty file named "disableHardCodedShiftDelete.xml", in "%APPDATA%\Notepad++\" directory (or in the Notepad++ installed directory in portable mode) to prevent this behaviour.

Fix notepad-plus-plus#14470
@donho donho closed this as completed in 53b5055 Dec 14, 2023
@donho
Copy link
Member

donho commented Jan 9, 2024

"disableHardCodedShiftDelete.xml" (renamed to "disableLineCopyCutDelete.xml") won't be used anymore.
This issue is reopened.

@donho donho reopened this Jan 9, 2024
donho added a commit to donho/notepad-plus-plus that referenced this issue Jan 9, 2024
… issue

This commit restore Scintilla Cut/Copy/Paste shortcuts. Also, the shortcuts Ctrl-C / Ctrl-X / Shift-DEL without selection to Copy / Cut / DEL entire line are removed in this commit due to several critical issues.

To Copy / Cut / DEL entire line, users are encouraged to use Scintilla default shortcuts set in Shortcut Mapper: Ctrl-Shift-X(SCI_LINECUT), Ctrl-L(SCI_LINECOPY) and Ctrl-Shift-L(SCI_LINEDELETE). You can remap them via Shortcut mapper.

Fix notepad-plus-plus#14568, fix notepad-plus-plus#14470
@donho donho closed this as completed in f7c44b4 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment