New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.5.1 Only installs as "Afrikaans" #3844
Comments
This screenshot isn't Dutch, but Afrikaans, correct? |
No other languages have been used on the server. It is set to english. Many
previous versions have been installed with no language issue. Np other
program has the issue. I only say Dutch .. because thats what google
translate thought it was.
Rich
On Nov 9, 2017 8:17 PM, "Niels de Groot" <notifications@github.com> wrote:
This screenshot isn't Dutch, but Afrikaans, correct?
Is there any language pack or setting related to Dutch or Afrikaans on the
server or in the user settings?
I mean is this a random language (it is also alphabetically first!) or
there anything on the server/user that could it Dutch/Afrtikaans?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3844 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfiRszZIR27N__F9tFV-ZveUuWE3QK1Eks5s07JJgaJpZM4QEx9T>
.
|
As of 7.5.6 still having install language issues. Corrected I believe it is Afrikaans, the language selection screen does not come up. I cannot use the -L command line switch, because English is not in the list of language codes because it is supposed to be default... it is not. This is Windows 2012 R2 Datacenter not standard. All language options on the servers are set to English. I have not seen this issue on any other installed program. This seems to have started with the 7.5 versions. Any Ideas ? |
I can install in Afrikkans and then use Settings -> Preferences -> General and drop back to English. So not the best route... but since no one seems to read these from NotePad++ my only option |
I read your comments but I'm not familiar with the code. So I can't help directly. I could only clarify your issue and hope somebody with more knowledge is able to do something about it. |
Correct .. I never receive the language screen though.
It goes straight to the setup page (in a different language).
I just click through it now .. and change the language after install.
Thank You
…On Sat, Jul 21, 2018 at 3:38 PM Rajendra Singh ***@***.***> wrote:
Ideally you should get below screen (1) when you double click installer
setup.exe
1. [image: image]
<https://user-images.githubusercontent.com/14791461/43039869-f9873286-8d53-11e8-9910-28c248ea7297.png>
2. [image: image]
<https://user-images.githubusercontent.com/14791461/43039873-07fea1c8-8d54-11e8-8182-246f93b200c8.png>
3. [image: image]
<https://user-images.githubusercontent.com/14791461/43039876-10008bfc-8d54-11e8-8d8d-ef2dda9b834a.png>
and the screen shared by you is 3rd step of installer.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3844 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfiRszoDf-TdkDqKd_KE56-6xw8SE-5eks5uI5FbgaJpZM4QEx9T>
.
|
please update your notepad++ to the latest version Notepad++ 7.6.6 and migrate or reinstall your plugins if you update from version 7.5.9 or below. thank you for your help and best regards. |
I'm having this exact same issue with System default is UK English. Language selection dropdown is not coming up. Edit: The 32-bit installer ( |
We've hit the same issue in npp.8.5.6.Installer.x64 |
|
Sorry for the inconvenience. There must be some special/different configuration on your OS (Winows 10 pro and Windows Server 2016). I have no solution yet for the moment. In the mean while, please use workaround solution to remove |
Could you post here a screenshot of your Windows "Welcome screen and new user accounts settings" and "Current language for non-Unicode programs"? (click on the Settings > Time & Language > Language > Administrative language settings > Copy settings...) @donho |
is already defined. Now, this documentation quote is interesting to the OP... as
though
Quote From https://documentation.help/CTRE-NSIS/Section4.10.html#4.10.1
I emphasised the important phrases! Step OP stated:
https://en.wikipedia.org/wiki/Comparison_of_Afrikaans_and_Dutch
IMO it is probably A registry key and value that is not unregistered at uninstall is:
Might be useful for remembering the language to upgrade though uninstall should remove it. Writes under the WOW6432Node key in X64. |
Thanks, I overlooked this.
IMO - this is definitely worth a try - you could try to create such PR and then ask the affected users here for testing ...
Yes, I know about that RegKey remnant. |
@MalakymR |
With testing a recompiled installer, I could not get the 1st language defined as English to be default as it kept defaulting to Afrikaans with an unsupported LCID. Seems the NSIS documentation is not reliable. So, I have added a PR to use a switch statement to detect if the LCID is supported by the installer and if not, set English as the value for |
The installer x86 & x64 which contains the fix of this issue (#14125) are available here: They are the latest version 8.5.7 and binaries are signed. |
Same issue, does not give initial language choice (except on machines where the original installer shows it). I have missed the details of the thread so haven't looked further into it myself yet. |
@MalakymR |
The problem seems to be caused by McAfee: #7574 (comment) So the issue is closed. |
Installers in order, reseting key to 1033 each time.
All show Afrikaans in the welcome window. When running these on a working system, I get 2 msgboxes before I am prompted for the installer language. On the problem system(s) this prompt is missing still. |
Is not that |
Sorry just made an assumption when typing, it was "Installer Language" in the registry each time. |
So that is really weird result. |
@MalakymR |
@MalakymR Could you please test one more installer? 1.test - delete completely the 2.test - create/update the above RegKey with that invalid value "Installer Language" and then start the installer npp.8.5.7.Installer.x64.MsgBoxes_InstallerLanguageFix_MUILangFixRegistryAndAlwaysShow_English1st.zip Edit: |
@donho |
That's a good news!
Could you be more precise please?
I just uncommented this line: and commented the following line; |
These two fixes should be enough (I can do a PR but I rather wait for another test from @MalakymR):
There is also a 4th potential fix - disabling the x64 Registry redirection and use the HKLM\SOFTWARE\Notepad++\InstallerLanguage for the x64 N++ installations. @mpheath has already correctly described most of the problems and possible solutions. But his PR is not working because while he fixed the possibly wrong regkey/$LANGUAGE value before invoking that NSIS MUI_LANGDLL_DISPLAY at .onInit, if NSIS own lang-detection method of that MUI_LANGDLL_DISPLAY fails before displaying the lang-selection dlg, NSIS engine reaches rather for the statically predefined first member of the N++ lang-list than for the already correctly preset $LANGUAGE var. And then it updates the $LANGUAGE accordingly (currently either with that Afrikaans or with the complete nonsense value "Installer Language", more description below). <tl;dr> All the problems reported:
What is behind it:
Current N++ installer:
There is one more way how to force a default value for the NSIS lang-selection dlg - using MUI_LANGDLL_REGISTRY_* before the "!insertmacro MUI_LANGDLL_DISPLAY", which is e.g. described in the NSIS example "C:\Program Files (x86)\NSIS\Examples\Modern UI\MultiLanguage.nsi". The regkey HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage then has to have the correct default value beforehand. </tl;dr> |
Deleted reg key. Msgboxes are 1033, 1033, Installer Language. Does not ask to pick a language. The key is created as "Installer Language". But the language at the welcome screen is English.
Reg key = "Installer Language". Msgboxes are 1033, 1033, Installer Language. Does not ask to pick a language. The welcome screen is in English. Reg key still shows "Installer Language"
|
@xomx |
@MalakymR Good news:
Bad news:
What the test-installer in your last two attempts did:
What to do next:
|
I have one more idea after considering this report:
So please try also these two test-installers (this time only check the lang-regkey value after the installer Welcome Screen shows up):
Note to the "native x64 NSIS installer": |
Any news about it? |
If that bump is for me - I am still waiting for another test by @MalakymR (or anyone else influenced), as I am not able to simulate all these NSIS error conditions myself. There is still a possibility that this is a N++ installer fault (and not a NSIS one). If I do not get further answers (let's say for more than a week), I will prepare at least a partial fix (the following is valid only for the problematic computers):
|
Should be able to test Monday or Tues. |
No language prompts for either. |
@xomx |
@donho A) Lang-selection dlg is shown but currently with invalid Afrikaans
B) Lang-selection dlg is NOT shown at all, user goes directly to the Welcome Screen installer dlg with invalid Afrikaans pre-selected
Anyway, I am going to create a PR for this probably on Saturday (sorry, not much free-time right now). |
Thank you @xomx |
@MalakymR Could you try it and tell me if you have English as Installer language please? |
A minimalist variant of the previous PR. Fix notepad-plus-plus#3844, fix notepad-plus-plus#7574, close notepad-plus-plus#14224
Appologies, this was around the time github forced MFA on everyone and it failed to work and took this long to get the issue resolved. (imo MFA should have only been pushed to bigger/more important projects first). |
Description of the Issue
Installing ver 7.5.1, 32 or 64 on MS Server 2012 R2 Standard. I get (Dutch) as the language. My servers are set to English. Previous versions all installed as English.
Attached screenshot is first screen after launching installer. It does not matter what login is used, or if you choose Install as Administrator.
Last version I have loaded was 7.4.2
Steps to Reproduce the Issue
Expected Behavior
Install in english or prompt for language
Actual Behavior
starts install in Dutch,
Debug Information
The text was updated successfully, but these errors were encountered: