Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.5.1 Only installs as "Afrikaans" #3844

Closed
rhisgen opened this issue Oct 24, 2017 · 57 comments
Closed

7.5.1 Only installs as "Afrikaans" #3844

rhisgen opened this issue Oct 24, 2017 · 57 comments

Comments

@rhisgen
Copy link

rhisgen commented Oct 24, 2017

Description of the Issue

Installing ver 7.5.1, 32 or 64 on MS Server 2012 R2 Standard. I get (Dutch) as the language. My servers are set to English. Previous versions all installed as English.
Attached screenshot is first screen after launching installer. It does not matter what login is used, or if you choose Install as Administrator.
Last version I have loaded was 7.4.2

Steps to Reproduce the Issue

  1. download 7.5.1 32 or 64bit
  2. try to install on MS Server 2012 R2 Standard

Expected Behavior

Install in english or prompt for language

Actual Behavior

starts install in Dutch,

Debug Information

notepad_dutch

@nlsdg
Copy link

nlsdg commented Nov 10, 2017

This screenshot isn't Dutch, but Afrikaans, correct?
Is there any language pack or setting related to Dutch or Afrikaans on the server or in the user settings?
I mean is this a random language (it is also alphabetically first!) or there anything on the server/user that could it Dutch/Afrikaans?

@rhisgen
Copy link
Author

rhisgen commented Nov 10, 2017 via email

@rhisgen
Copy link
Author

rhisgen commented May 4, 2018

As of 7.5.6 still having install language issues. Corrected I believe it is Afrikaans, the language selection screen does not come up. I cannot use the -L command line switch, because English is not in the list of language codes because it is supposed to be default... it is not. This is Windows 2012 R2 Datacenter not standard. All language options on the servers are set to English. I have not seen this issue on any other installed program. This seems to have started with the 7.5 versions. Any Ideas ?

@rhisgen rhisgen changed the title 7.5.1 Only installs as "Dutch" 7.5.1 Only installs as "Afrikaans" May 4, 2018
@rhisgen
Copy link
Author

rhisgen commented May 4, 2018

I can install in Afrikkans and then use Settings -> Preferences -> General and drop back to English. So not the best route... but since no one seems to read these from NotePad++ my only option

@nlsdg
Copy link

nlsdg commented May 5, 2018

I read your comments but I'm not familiar with the code. So I can't help directly. I could only clarify your issue and hope somebody with more knowledge is able to do something about it.

@SinghRajenM
Copy link
Contributor

Ideally you should get below screen (1) when you double click installer setup.exe

  1. image
  2. image
  3. image

and the screen shared by you is 3rd step of installer.

@rhisgen
Copy link
Author

rhisgen commented Jul 23, 2018 via email

@MetaChuh
Copy link

MetaChuh commented May 2, 2019

please update your notepad++ to the latest version Notepad++ 7.6.6 and migrate or reinstall your plugins if you update from version 7.5.9 or below.
if your issue still persists, and it is still of relevance, please feel free to file a new issue as easy to understand and reproducible as possible.

thank you for your help and best regards.

@levid0s
Copy link

levid0s commented Apr 12, 2023

I'm having this exact same issue with npp.8.5.2.Installer.x64.exe on a virtual Windows 10 22H2 (19045.27728)

System default is UK English.

Language selection dropdown is not coming up.

Edit: The 32-bit installer (npp.8.5.2.Installer.exe) does give me the Language selection dropdown with Afrikaans selected by default.

@MalakymR
Copy link

MalakymR commented Sep 5, 2023

We've hit the same issue in npp.8.5.6.Installer.x64

@donho
Copy link
Member

donho commented Sep 5, 2023

@MalakymR & @levid0s
Could you provide your Debug Info via menu ? > Debug Info... please?

@MalakymR
Copy link

MalakymR commented Sep 6, 2023

@donho

Notepad++ v8.5.6 (64-bit)
Build time : Aug 15 2023 - 15:29:28
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : ON
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 10 Pro (64-bit)
OS Version : 22H2
OS Build : 19045.3324
Current ANSI codepage : 1252
Plugins :
mimeTools (2.9)
NppConverter (4.5)
NppExport (0.4)

@donho donho reopened this Sep 6, 2023
@donho
Copy link
Member

donho commented Sep 6, 2023

Sorry for the inconvenience. There must be some special/different configuration on your OS (Winows 10 pro and Windows Server 2016). I have no solution yet for the moment. In the mean while, please use workaround solution to remove %APPDATA%\Notepad++\nativeLang.xml.

@xomx
Copy link
Contributor

xomx commented Sep 7, 2023

@MalakymR

Could you post here a screenshot of your Windows "Welcome screen and new user accounts settings" and "Current language for non-Unicode programs"?

(click on the Settings > Time & Language > Language > Administrative language settings > Copy settings...)

AdminLangSettings

@donho
We could at least improve the state when a user suddenly never receives the installer language selecting screen. If NSIS decides somehow that the computer is only able to display one language (Registry errors, code page issues etc), it will not show that dialog at all. But we can override this with using the MUI_LANGDLL_ALLLANGUAGES.

@mpheath
Copy link
Contributor

mpheath commented Sep 8, 2023

@xomx

But we can override this with using the MUI_LANGDLL_ALLLANGUAGES.

is already defined.


Now, this documentation quote is interesting to the OP... as Afrikaans is the first language in the source.

!insertmacro MUI_LANGUAGE "Afrikaans"

though English should be the first language at line 23 ?

Quote From https://documentation.help/CTRE-NSIS/Section4.10.html#4.10.1

4.10.1 Language Selection

When the installer starts up it goes through these steps to select the interface language:

  1. Get user's default Windows UI language
  2. Find a perfect match for the language
  3. If there is no perfect match, find a primary language match
  4. If there is no match, use the first language defined in the script (make sure your first language is a common one like English)
  5. If the language variable $LANGUAGE has changed during .onInit, NSIS goes through steps 2 to 4 again.

I emphasised the important phrases! Step 5 might be causing a re-evaluation to ocurr, leading to no perfect match, so the first language is Afrikaans which is set as the install language.

OP stated:

I get (Dutch) as the language.

https://en.wikipedia.org/wiki/Comparison_of_Afrikaans_and_Dutch

Afrikaans is a daughter language of Dutch

IMO it is probably Afrikaans and was mistaken for Dutch .


A registry key and value that is not unregistered at uninstall is:

WriteRegStr HKLM "SOFTWARE\${APPNAME}" 'InstallerLanguage' '$Language'

Might be useful for remembering the language to upgrade though uninstall should remove it. Writes under the WOW6432Node key in X64.

@MalakymR
Copy link

MalakymR commented Sep 8, 2023

@xomx

Screenshot 2023-09-08 094809

@xomx
Copy link
Contributor

xomx commented Sep 8, 2023

@mpheath

MUI_LANGDLL_ALLLANGUAGES...
is already defined.

Thanks, I overlooked this.

though English should be the first language at line 23 ?

IMO - this is definitely worth a try - you could try to create such PR and then ask the affected users here for testing ...

A registry key and value that is not unregistered at uninstall is:

WriteRegStr HKLM "SOFTWARE\${APPNAME}" 'InstallerLanguage' '$Language'

Might be useful for remembering the language to upgrade though uninstall should remove it. Writes under the WOW6432Node key in X64.

Yes, I know about that RegKey remnant.
The question is whether we should even be trying to fix accidents like this.

@xomx
Copy link
Contributor

xomx commented Sep 8, 2023

@MalakymR
Thanks for the screenshot, it seems ok.
I asked for that because of I once had a similar Afrikaans-problem. I was doing too many things at once and was inattentive, so I accidentally clicked over the language selection screen during Windows installation, where the Afrikaans is the first item too. I repaired that later but then, when I e.g. created a new user account, it was back.

@mpheath
Copy link
Contributor

mpheath commented Sep 9, 2023

With testing a recompiled installer, I could not get the 1st language defined as English to be default as it kept defaulting to Afrikaans with an unsupported LCID. Seems the NSIS documentation is not reliable. So, I have added a PR to use a switch statement to detect if the LCID is supported by the installer and if not, set English as the value for $LANGUAGE.

@donho
Copy link
Member

donho commented Sep 16, 2023

The installer x86 & x64 which contains the fix of this issue (#14125) are available here:
http://download.notepad-plus-plus.org/repository/MISC/fixInstallLangIssue/

They are the latest version 8.5.7 and binaries are signed.
Please test the installer of your choice, and confirm me if this issue has been fixed.

@donho
Copy link
Member

donho commented Sep 20, 2023

@rhisgen @levid0s @MalakymR
Could you test the fix mentioned above please?

@MalakymR
Copy link

Same issue, does not give initial language choice (except on machines where the original installer shows it). I have missed the details of the thread so haven't looked further into it myself yet.

@donho
Copy link
Member

donho commented Sep 21, 2023

@MalakymR
Thank you for testing.
Have you McAfee installed on the PC in question?
As posted here:
#7574 (comment)

@donho
Copy link
Member

donho commented Sep 22, 2023

The problem seems to be caused by McAfee: #7574 (comment)

So the issue is closed.

@donho donho closed this as completed Sep 22, 2023
@MalakymR
Copy link

MalakymR commented Sep 26, 2023

Installers in order, reseting key to 1033 each time.

  1. npp.8.5.7.Installer.x64.test-msgboxes
    1033
    1033
    InstallerLanguage
    (reg = Installer Language)

  2. npp.8.5.7.Installer.x64.test-msgboxes-disabled-x64redirector
    1033
    InstallerLanguage
    InstallerLanguage
    (reg = 1033)

  3. npp.8.5.7.Installer.x64.test-msgboxes-hack-Afrikaans
    1033
    1033
    InstallerLanguage
    (reg = Installer Language)

All show Afrikaans in the welcome window.

When running these on a working system, I get 2 msgboxes before I am prompted for the installer language. On the problem system(s) this prompt is missing still.

@xomx
Copy link
Contributor

xomx commented Sep 26, 2023

Is not that InstallerLanguage rather "Installer Language"? (even your ProcMon log shows that)
Edit: I mean the data, not the name of that RegKey, that is InstallerLanguage for sure.

@MalakymR
Copy link

Sorry just made an assumption when typing, it was "Installer Language" in the registry each time.

@xomx
Copy link
Contributor

xomx commented Sep 26, 2023

So that is really weird result.
I will continue in this later, but it seems that N++ installer is not responsible for all of this. More later.

@donho
Copy link
Member

donho commented Sep 26, 2023

@MalakymR
I have tried to set English as default value while the detection is failed. Could you try the following binaries please?
http://download.notepad-plus-plus.org/repository/MISC/setEnglishAsDefaultLang

@donho donho reopened this Sep 26, 2023
@xomx
Copy link
Contributor

xomx commented Sep 26, 2023

@MalakymR
Ok, I think I got it. If I am right I will be able to fix all that weird things at once (defaulting to Afrikaans, not showing lang-selector dlg at all, writting that nonsence "Installer Language" etc...).

Could you please test one more installer?

1.test - delete completely the HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage RegKey before you start that installer.

2.test - create/update the above RegKey with that invalid value "Installer Language" and then start the installer

npp.8.5.7.Installer.x64.MsgBoxes_InstallerLanguageFix_MUILangFixRegistryAndAlwaysShow_English1st.zip

Edit:
@donho
You posted at the same time.
I think I know what the problem is (I was able to reproduce that somehow in a VM).

@xomx
Copy link
Contributor

xomx commented Sep 26, 2023

@donho
Your installer works ok, but it did not fix all the problems.
Did you use the "!define MUI_LANGDLL_ALWAYSSHOW"?

@donho
Copy link
Member

donho commented Sep 26, 2023

@xomx

Your installer works ok,

That's a good news!

but it did not fix all the problems.

Could you be more precise please?

Did you use the "!define MUI_LANGDLL_ALWAYSSHOW"?

I just uncommented this line:
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/installer/nsisInclude/langs4Installer.nsh#L19

and commented the following line;
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/installer/nsisInclude/langs4Installer.nsh#L38

@donho donho removed the invalid Issues and PRs with missing minimum requirements data, or insufficient understandable explanation label Sep 26, 2023
@xomx
Copy link
Contributor

xomx commented Sep 27, 2023

@donho

These two fixes should be enough (I can do a PR but I rather wait for another test from @MalakymR):

  1. nppSetup.nsi
    Unfortunately some of the users already have wrong "Installer Language" value in their regkey HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage {which then can also lead to the Afrikaans problem later), so at NSIS .onInit N++ has to either check for that and possibly correct it to our factory default (1033 == English) or delete that regkey completely (simulating a fresh state).

  2. langs4Installer.nsh
    Moving English at the 1st position (default lang) + using the MUI_LANGDLL_ALWAYSSHOW, i.e.:

; Set languages (first is default language)
!define MUI_LANGDLL_ALWAYSSHOW ; do not skip the lang-selection dlg even when something fails
!define MUI_LANGDLL_ALLLANGUAGES
;Languages

  !insertmacro MUI_LANGUAGE "English"
  !insertmacro MUI_LANGUAGE "Afrikaans"
  !insertmacro MUI_LANGUAGE "Albanian"
  ...
  1. nppSetup.nsi (unsure, I rather wait for another testing)
    If the above two patches will not be enough, I will also additionally use the MUI_LANGDLL_REGISTRY_* way described below.
    I think that this is not needed, but it has to be confirmed on that user's problematic computers.

There is also a 4th potential fix - disabling the x64 Registry redirection and use the HKLM\SOFTWARE\Notepad++\InstallerLanguage for the x64 N++ installations.
But this is not needed if we consider as ok sharing the same installation language selection between the x86 & x64 N++ installations (which is IMO ok).

@mpheath has already correctly described most of the problems and possible solutions. But his PR is not working because while he fixed the possibly wrong regkey/$LANGUAGE value before invoking that NSIS MUI_LANGDLL_DISPLAY at .onInit, if NSIS own lang-detection method of that MUI_LANGDLL_DISPLAY fails before displaying the lang-selection dlg, NSIS engine reaches rather for the statically predefined first member of the N++ lang-list than for the already correctly preset $LANGUAGE var. And then it updates the $LANGUAGE accordingly (currently either with that Afrikaans or with the complete nonsense value "Installer Language", more description below).

<tl;dr>

All the problems reported:

  1. Some users get Afrikaans pre-selected as the default option in their N++ installer lang-selection dlg.
  2. One reported similar problem when using automatic clickthrough install method via winget (got the N++ preinstalled with that Afrikaans lang, this is probably only a flavor of the previous No.1).
  3. Some do not get that lang-selection dlg at all (they go straight to the installation Welcome Screen instead and with that wrong Afrikaans display-lang).
  4. Users having the previous problem No.3 reported weird "Installer Language" value written in their regkey HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage
  5. One got that lang-selection dlg after all, but only when used the x86 N++ installer (and then there is again the wrong Afrikaans pre-selected).
  6. Some even got that Afrikaans problem back at the next N++ installation even when they previously manually fixed that installer language to something else.

What is behind it:

  • in Windows is used a locale like Icelandic, which has no counterpart in the N++ list of the supported langs for the NSIS installer
  • or a possible failure/defect in detection of the current locale in Windows (a Registry corruption etc)
  • or maybe a non-standard variant of Windows (server or a somehow customized Windows editions etc)

Current N++ installer:

  • at .onInit N++ tries to find a previously used installer language in the regkey HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage
  • if that regkey has been found, it then presets the NSIS $LANGUAGE (if not, the unmodified $LANGUAGE at this stage contains the NSIS default)
  • then the .onInit continues with the line "!insertmacro MUI_LANGDLL_DISPLAY", which should invoke the NSIS lang-selection dlg
  • but when Windows locale is e.g. Icelandic, NSIS cannot get a match inside the N++ lang-list in the langs4Installer.nsh and offers the 1st one in that lang-list instead (which is currently "!insertmacro MUI_LANGUAGE "Afrikaans")
  • but if something failed in the NSIS logic for the MUI_LANGDLL_DISPLAY, the lang-selection dlg is then not showed at all and the 1st N++ lang Afrikaans is pre-selected directly and moreover the nonsense "Installer Language" value (evidently a NSIS default value somewhere) is then set to the NSIS $LANGUAGE and therefore that nonsense value is written in the regkey after!

There is one more way how to force a default value for the NSIS lang-selection dlg - using MUI_LANGDLL_REGISTRY_* before the "!insertmacro MUI_LANGDLL_DISPLAY", which is e.g. described in the NSIS example "C:\Program Files (x86)\NSIS\Examples\Modern UI\MultiLanguage.nsi". The regkey HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage then has to have the correct default value beforehand.

</tl;dr>

@MalakymR
Copy link

@MalakymR Ok, I think I got it. If I am right I will be able to fix all that weird things at once (defaulting to Afrikaans, not showing lang-selector dlg at all, writting that nonsence "Installer Language" etc...).

Could you please test one more installer?

1.test - delete completely the HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage RegKey before you start that installer.

Deleted reg key. Msgboxes are 1033, 1033, Installer Language. Does not ask to pick a language. The key is created as "Installer Language". But the language at the welcome screen is English.

2.test - create/update the above RegKey with that invalid value "Installer Language" and then start the installer

Reg key = "Installer Language". Msgboxes are 1033, 1033, Installer Language. Does not ask to pick a language. The welcome screen is in English. Reg key still shows "Installer Language"

npp.8.5.7.Installer.x64.MsgBoxes_InstallerLanguageFix_MUILangFixRegistryAndAlwaysShow_English1st.zip

@donho
Copy link
Member

donho commented Sep 28, 2023

@xomx
Thank you for your explanation.
I let you create a PR for fixing this bug then.

@xomx
Copy link
Contributor

xomx commented Sep 28, 2023

@MalakymR
Thanks for all the testing. I am able to simulate e.g. that Icelandic Windows locale in a VM, but not such obvious NSIS lang-selector engine failures.

Good news:

  • now we have at least a way how to force the English as the installer default instead of that Afrikaans

Bad news:

  • even when the last test-installer uses the NSIS MUI_LANGDLL_ALWAYSSHOW, the lang-selection dlg is still not shown at all and that nonsense "Installer Language" value is still generated somehow!

What the test-installer in your last two attempts did:

  • the 1st msgbox shows us in both cases the NSIS default for the NSIS $LANGUAGE variable at .onInit (which is probably the current Windows locale), so the 1st "1033" is expected on your machine
  • 2nd "1033" is shown after we read a possible previous lang-regkey from the previous installation, the possible nonsence "Installer Language" value is corrected before (to our "factory default" == English)
  • then there is that missing langs-selection dlg, which looks like as a total NSIS lang-engine selector failure
  • then we got the last msgbox with "Installer Language", which looks also as the total NSIS failure because of it evidently uses that nonsense value for overwriting our $LANGUAGE variable at the end of the installer .onInit

What to do next:

  • before I create at least a partial fix for this in N++ installer (and eventually fill a NSIS-bugreport), I need to be sure that this is not a N++ fault but a NSIS one (and for a possible future NSIS-bugreport, I will also need a simple POC installer script)
  • so the next test-installer is only a slightly modified NSIS example skript "C:\Program Files (x86)\NSIS\Examples\Modern UI\MultiLanguage.nsi":
    MultiLanguage-test.zip
  • please repeat the last two tests with it (this time always let the test-installer finish its installation and check for the NSIS default regkey "HKCR\SOFTWARE\Modern UI Test\Installer Language")

@xomx
Copy link
Contributor

xomx commented Sep 28, 2023

@MalakymR

I have one more idea after considering this report:

@levid0s
Language selection dropdown is not coming up.
Edit: The 32-bit installer (npp.8.5.2.Installer.exe) does give me the Language selection dropdown with Afrikaans selected by default.

So please try also these two test-installers (this time only check the lang-regkey value after the installer Welcome Screen shows up):

  1. x86 installer, check the HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage :
    npp.8.5.7.Installer.MsgBoxes_InstLangRegFix_MUILangAlwaysShow_English1st_usualX86NSIS.zip
  2. native x64 NSIS installer, check the HKLM\SOFTWARE\Notepad++\InstallerLanguage :
    npp.8.5.7.Installer.x64.MsgBoxes_InstLangRegFix_MUILangAlwaysShow_English1st_nativeX64NSIS.zip

Note to the "native x64 NSIS installer":
Nowadays the NSIS installers produced for x64-apps are still the 32-bit x86 binaries. This is because the official NSIS source code can be compiled as the 64-bit as well, but the System plug-in is still not fully functional. But there is an undocumented NSIS switch Target AMD64-Unicode and then one also needs 64-bit NSIS stubs and plugins (relevant binaries available e.g. from this fork: https://github.com/negrutiu/nsis/releases )

@donho
Copy link
Member

donho commented Oct 1, 2023

Any news about it?

@xomx
Copy link
Contributor

xomx commented Oct 1, 2023

@donho

If that bump is for me - I am still waiting for another test by @MalakymR (or anyone else influenced), as I am not able to simulate all these NSIS error conditions myself. There is still a possibility that this is a N++ installer fault (and not a NSIS one).

If I do not get further answers (let's say for more than a week), I will prepare at least a partial fix (the following is valid only for the problematic computers):

  • lang-selection installer dlg will be still missing, but now the automatically selected lang will be English and not the Afrikaans
  • the above also means that any previously selected correct lang (stored in the N++ regkey) will be overridden to English
  • the possible wrong "Installer Language" value generated by NSIS for the $LANGUAGE var will be corrected to English too before writing to the regkey

@MalakymR
Copy link

MalakymR commented Oct 1, 2023

Should be able to test Monday or Tues.

@MalakymR
Copy link

MalakymR commented Oct 3, 2023

@MalakymR

So please try also these two test-installers (this time only check the lang-regkey value after the installer Welcome Screen shows up):

1. x86 installer, check the HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage :
   [npp.8.5.7.Installer.MsgBoxes_InstLangRegFix_MUILangAlwaysShow_English1st_usualX86NSIS.zip](https://github.com/notepad-plus-plus/notepad-plus-plus/files/12754501/npp.8.5.7.Installer.MsgBoxes_InstLangRegFix_MUILangAlwaysShow_English1st_usualX86NSIS.zip)
  1. Msgbox = 1033, 1033, Installer Language
    Welcome = Afrikaans
    Reg = Installer Language (in HKLM\SOFTWARE\WOW6432Node\Notepad++\InstallerLanguage)
2. native x64 NSIS installer, check the HKLM\SOFTWARE\Notepad++\InstallerLanguage :
   [npp.8.5.7.Installer.x64.MsgBoxes_InstLangRegFix_MUILangAlwaysShow_English1st_nativeX64NSIS.zip](https://github.com/notepad-plus-plus/notepad-plus-plus/files/12754509/npp.8.5.7.Installer.x64.MsgBoxes_InstLangRegFix_MUILangAlwaysShow_English1st_nativeX64NSIS.zip)
  1. Msgbox = 1033, 1033, Installer Language
    Welcome = English
    Reg = Installer Language (in HKLM\SOFTWARE\Notepad++\InstallerLanguage)

No language prompts for either.

@xomx
Copy link
Contributor

xomx commented Oct 3, 2023

@MalakymR
Thank you.
Can I ask also for the modified NSIS-example test above (in the file MultiLanguage-test.zip there...)?

@donho
Copy link
Member

donho commented Oct 4, 2023

@xomx
I just have had the confirmation of fix here: #7574 (comment)
What do we need more for a PR for fixing this issue?

@xomx
Copy link
Contributor

xomx commented Oct 5, 2023

@donho
Users are experiencing different types of this Afrikaans-problem (note that in your mentioned #7574 (comment) user was shown the lang-selection dlg while e.g. to the @MalakymR here was not).

A) Lang-selection dlg is shown but currently with invalid Afrikaans

  • this type is better, we can/will fully fix that by that "English-1st-in-our-static-lang-list"
  • it is caused either by a specific Windows locale like Icelandic or by a previous invalid N++ lang-regkey value

B) Lang-selection dlg is NOT shown at all, user goes directly to the Welcome Screen installer dlg with invalid Afrikaans pre-selected

  • this one is worse and currently not fully fixable, I can ensure forcing default English instead of that Afrikaans and pre/post-correction of the lang-regkey but nothing more
  • with this type any previous correct lang-regkey is ignored totally and overwritten to the nonsense value "Installer Language" during the installation (the $LANGUAGE installer variable is overwritten at runtime automatically by NSIS-engine, then this is consequently also written to the lang-regkey later, even when I patched and forced that English for the Welcome Screen, which IS then in English...)
  • this one seems to me as a NSIS fault (I need that one more test by @MalakymR for confirmation and for POC for a future possible NSIS bug-report...)

Anyway, I am going to create a PR for this probably on Saturday (sorry, not much free-time right now).
Is it ok or you need it earlier?

@donho
Copy link
Member

donho commented Oct 6, 2023

Thank you @xomx
Just saw your comment and analysis.
Saturday it's OK to me, but since you have done the PR...
I just reviewed your PR and let's talk there (in PR)

@donho
Copy link
Member

donho commented Oct 8, 2023

@MalakymR
I have never got your answer for the test result of following binaries:
http://download.notepad-plus-plus.org/repository/MISC/setEnglishAsDefaultLang

Could you try it and tell me if you have English as Installer language please?
And especially, could you let me know the language of Notepad++ after installation?

@donho donho closed this as completed in 64e95cc Oct 10, 2023
donho pushed a commit to donho/notepad-plus-plus that referenced this issue Oct 20, 2023
@MalakymR
Copy link

@MalakymR I have never got your answer for the test result of following binaries: http://download.notepad-plus-plus.org/repository/MISC/setEnglishAsDefaultLang

Could you try it and tell me if you have English as Installer language please? And especially, could you let me know the language of Notepad++ after installation?

Appologies, this was around the time github forced MFA on everyone and it failed to work and took this long to get the issue resolved. (imo MFA should have only been pushed to bigger/more important projects first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants