Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English.xml has superflous spaces before colon (:) #4628

Closed
ordtrogen opened this issue Jul 4, 2018 · 1 comment
Closed

English.xml has superflous spaces before colon (:) #4628

ordtrogen opened this issue Jul 4, 2018 · 1 comment
Labels
translation Issues or PRs related to translation of N++ UI

Comments

@ordtrogen
Copy link
Contributor

ordtrogen commented Jul 4, 2018

For example line 346: <Item id="1620" name="&amp;Find what :"/>

Note there is a space character before the colon at the end of the line. This is standard practice in French, for example, but not in English. The space before colon is not there everywhere in english.xml, only 16 occurrences

Suggestion: remove these spaces in english.xml and only add them in the translation to a language that requires them.

@ArkadiuszMichalski
Copy link
Contributor

ArkadiuszMichalski commented Sep 15, 2020

@donho
In most case in english.xml this additional space is not added, only in:

<Item id="1611" name="Rep&amp;lace with :"/>
<Item id="1654" name="Filter&amp;s :"/>
<Item id="1655" name="Dir&amp;ectory :"/>
<Item id="6217" name="Width :"/>
<Item id="6219" name="Blink rate :"/>
<Item id="6411" name="Default language :"/>
<Item id="6306" name="Max. number of entries :"/>
<Item id="6803" name="Directory :"/>
<Item id="6814" name="Valid value : 1 - 9"/>
<Item id="8006" name="Macro to run :"/>
<Item id="2030" name="Initial number :"/>
<Item id="2031" name="Increase by :"/>
<Item id="2036" name="Repeat :"/>
<Item id="1711" name="&amp;Find what :"/>
<replace-in-files-confirm-directory value="Are you sure you want to replace all occurrences in :"/>
<replace-in-files-confirm-filetype value="For file type :"/>

It's intentional? If not it can be easy fix (also in english_customizable.xml) and close this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Issues or PRs related to translation of N++ UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants