Replace auto-complete link mini dlg with slider #13163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Item id="6860" name="Matched pair 1:"/> | ||
| <Item id="6863" name="Matched pair 2:"/> | ||
| <Item id="6866" name="Matched pair 3:"/> | ||
| <Item id="6860" name="Matched pair 1 :"/> |
There was a problem hiding this comment.
Why we add space before ":"? Is it because of the visual improvement? I've checked several programs and none add spaces here. We currently have an open issue regarding this and I don't know what to do with it.
#4628
There was a problem hiding this comment.
I did not know about that issue. I just wanted to keep it consistent.
IMHO I would not add space before :.
|
Very nice! 👍 Thank you. |
|
@Yaron10 |
|
Great. Thank you for your work. |
ozone10
force-pushed
the
PrefDlgReplaceLinkMiniDlg
branch
from
1f53672
to
ea9c618
Compare
ozone10
force-pushed
the
PrefDlgReplaceLinkMiniDlg
branch
from
ea9c618
to
1c45f50
Compare
May I know which ones? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13162