Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ANSI charset is detected #4878

Closed
vrubleg opened this issue Sep 25, 2018 · 1 comment
Closed

Wrong ANSI charset is detected #4878

vrubleg opened this issue Sep 25, 2018 · 1 comment

Comments

@vrubleg
Copy link

vrubleg commented Sep 25, 2018

Description of the Issue

Sometimes Notepad++ detects text files with Windows-1251 encoding as Macintosh encoding.
This screenshot was made on this file, latest N++ version is still affected.
Maybe it's better to take into account only current system ANSI codepage for legacy ANSI text files?
(It's a copy of this issue from the old bug tracker).

Steps to Reproduce the Issue

  1. Download this file.
  2. Open it in the Notepad++.

Expected Behavior

System ANSI codepage should be used.

Actual Behavior

Wrong charset is detected. Notepad++ displays broken text.

@vrubleg vrubleg changed the title Invalid ANSI encoding is detected Wrong ANSI charset is detected Sep 25, 2018
@donho donho closed this as completed in bfb7e86 Nov 9, 2018
@vtk51
Copy link

vtk51 commented May 8, 2019

Here is another sample file of wrong detect.
IM.txt
with manual encoding Windows-1251 selection works fine.

kspalaiologos pushed a commit to kspalaiologos/notepad-plus-plus that referenced this issue Jan 17, 2021
This PR updates uchardet (https://www.freedesktop.org/wiki/Software/uchardet/) to the newest stable version (0.0.6).
This version seems to improve UTF-8 detection quality, so updating this dependency is expected to squash numerous charset detection issues.

Fixes notepad-plus-plus#4878, Fixes notepad-plus-plus#4767, Fixes notepad-plus-plus#4428, Fixes notepad-plus-plus#4246, Fixes notepad-plus-plus#3705, Fixes notepad-plus-plus#3588, Fixes notepad-plus-plus#431, Closes notepad-plus-plus#4925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants