Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert in AutoCompletion::isAllDigits #5280

Closed
wqweto opened this issue Jan 29, 2019 · 0 comments
Closed

Assert in AutoCompletion::isAllDigits #5280

wqweto opened this issue Jan 29, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@wqweto
Copy link

wqweto commented Jan 29, 2019

I've been dog-fooding 32-bit Unicode Debug build here and upon entering cyrillic letters an assert poped up

image

In call-stack the last non-runtime line was

return std::all_of(str.begin(), str.end(), ::isdigit);

Apparently you cannot use MBCS designed isdigit with wchar_t . The only other place isdigit is (mis)used is somewhere in WindowsDlg.cpp.

Both a simple fix to replace w/ _istdigit, will send PR if assigned.

@donho donho added the accepted label Jun 9, 2019
@donho donho self-assigned this Jun 9, 2019
@donho donho added this to the 7.x (master) milestone Jun 9, 2019
@donho donho closed this as completed in 344850a Jun 9, 2019
kspalaiologos pushed a commit to kspalaiologos/notepad-plus-plus that referenced this issue Jan 17, 2021
Fix debug mode assert in `AutoCompletion::isAllDigits` methode while inputting non ASCII characters.

Fix notepad-plus-plus#5280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants