We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoCompletion::isAllDigits
I've been dog-fooding 32-bit Unicode Debug build here and upon entering cyrillic letters an assert poped up
Unicode Debug
In call-stack the last non-runtime line was
return std::all_of(str.begin(), str.end(), ::isdigit);
Apparently you cannot use MBCS designed isdigit with wchar_t . The only other place isdigit is (mis)used is somewhere in WindowsDlg.cpp.
isdigit
wchar_t
WindowsDlg.cpp
Both a simple fix to replace w/ _istdigit, will send PR if assigned.
_istdigit
The text was updated successfully, but these errors were encountered:
344850a
Fix assert in AutoCompletion::isAllDigits methode
b117a1b
Fix debug mode assert in `AutoCompletion::isAllDigits` methode while inputting non ASCII characters. Fix notepad-plus-plus#5280
donho
No branches or pull requests
I've been dog-fooding 32-bit
Unicode Debug
build here and upon entering cyrillic letters an assert poped upIn call-stack the last non-runtime line was
Apparently you cannot use MBCS designed
isdigit
withwchar_t
. The only other placeisdigit
is (mis)used is somewhere inWindowsDlg.cpp
.Both a simple fix to replace w/
_istdigit
, will send PR if assigned.The text was updated successfully, but these errors were encountered: