Bug with RegEx and (Book)marked lines

[rddim]

Description of the Issue

When I use a regex to mark and bookmark repeated lines and after that use Remove Unmarked Lines and Undo all the lines (with the uniques one) between 1st and last bookmarked lines are also marked.

Steps to Reproduce the Issue

1. In a text file type:

aaa
bbb
ccc
aaa
aaa
ddd
eee
bbb
bbb

2. Go to Search > Mark...
3. In Find what: type ^(.*)$\s+(?=(^.*$\s+)*\1) or ^(.*?)$\s+?^(?=.*^\1$)
4. Check the Bookmark line, Regular expression and . matches newline
5. Click Mark All
6. Go to Search > Bookmark > Remove Unmarked Lines
7. Click on Undo icon or Edit > Undo

Expected Behavior

After the step 7 I expect to seen the result that is after the step 5

Actual Behavior

The unique lines between 1st and last bookmarked lines are also marked.

Debug Information

Notepad++ v7.6.3 (64-bit)
Build time : Jan 27 2019 - 17:16:47
Path : D:\Install\Office Programs\Notepad++\notepad++.exe
Admin mode : ON
Local Conf mode : ON
OS : Windows 7 (64-bit)
Plugins : AutoSave.dll ComparePlugin.dll VisualStudioLineCopy.dll

Edit:

1. If I use Normal search mode and Find what: aaa or bbb the result is normal with or without bookmarks
2. If I use step 3 but type aaa or bbb the result is also normal with or without bookmarks

[sasumner]

To my knowledge, Undo refers to textual changes only and not bookmarking (or other actions). You are certainly free to complain about it not working well with bookmarking.

[rddim]

OK, I make another test:
After step 6 and Clear All Bookmarks the result is the same after Undo

Edit:

1. If I use Normal search mode and Find what: aaa or bbb the result is normal with or without bookmarks
2. If I use step 3 but type aaa or bbb the result is also normal with or without bookmarks

[sasumner]

Unlike @MetaChuh , I can't follow the reproduction steps well enough to make a determination. @rddim please provide a clearer set of steps, showing what you expect at each step. If this doesn't happen in a few days, I'm going to go ahead and close this issue.

[rddim]

@sasumner I am away from home and my PC now. In the middle of the next week I will be available. На 7 август 2019 г. 21:45:22 GMT+03:00, sasumner <notifications@github.com> написа:

…

Unlike @MetaChuh , I can't follow the reproduction steps well enough to make a determination. @rddim please provide a clearer set of steps, showing what you expect at each step. If this doesn't happen in a few days, I'm going to go ahead and close this issue. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #5361 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[sasumner]

@rddim That's fine, I will give until 19 Aug 2019 before auto-closure.

[rddim]

@sasumner

After following all the 7 steps I expect only lines numbers 1 2 4 and 8 to be marked and bookmarked.

[sasumner]

@rddim Okay, I think I see it now. Sorry for not seeing it earlier and thank you for the clarification.

The complaint is that after the 7 steps to reproduce there is too much (red)marking: Lines 1-8 are all completely (red)marked when the contention is that only lines 1,2,4,8 should be. There is no complaint about how the bookmarks end up after the undo (at least I don't think there is).

[The source of my confusion: The term "mark" is unfortunate (for me at least), because I get it confused between the (red)marking of text and the (book)marking of lines. I would much rather have "marking" be officially called "red-marking", but of course the color can be changed by the user -- red is only the default -- so that's probably not a good idea.]

[sasumner]

So I still think that "Undo refers to textual changes only...". Consider an initial state:

Then make this selection:

Press Delete key to get:

Press ctrl+z (Undo) to get:

Note lack of restoration of redmarking on line 4.

This works similarly for "styling" (similar sequence):

In short, I don't think we can call this a "bug". If it is a "feature request" then maybe I feel better about that. :-)

[rddim]

Then you can close this issue...