Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent multi-line tab click activation behavior #6274

Closed
balagansky opened this issue Oct 26, 2019 · 4 comments
Closed

Inconsistent multi-line tab click activation behavior #6274

balagansky opened this issue Oct 26, 2019 · 4 comments

Comments

@balagansky
Copy link
Contributor

Description of the Issue

When multi-line tabs are enabled, behavior when clicking on a tab is inconsistent depending on whether there is one row or more than one row of tabs.

When there is one row of tabs, mouse down activates an inactive tab. But when there multiple rows, inactive tabs only become active on mouse up.

Steps to Reproduce the Issue

  1. Enable multi-line tabs
  2. Load up tabs such that there is more than one tab row
  3. Click on an inactive tab

Expected Behavior

Inactive tabs always become active on mouse down

Actual Behavior

Inactive tabs only become active on mouse up when there are multiple tab rows

Debug Information

Notepad++ v7.7.1 (32-bit)
Build time : Oct 7 2019 - 19:07:35
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 1803
OS Build : 17134.1069
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

Also reproducible on master/HEAD

npptabclick

@balagansky
Copy link
Contributor Author

The changes suggested by @AngryGamer here seem to fix this: #6273 (comment)

@donho
Copy link
Member

donho commented Oct 28, 2019

v7.7.1 is not head version and such issue could be fixed in v7.8
I cannot reproduce the issue you reported at all by using v7.8.

@balagansky
Copy link
Contributor Author

I can reproduce it just as easily on 7.8, on multiple machines.

I am truly baffled that you cannot.

@donho
Copy link
Member

donho commented Nov 6, 2019

Sorry. I read it again and it's not a bug to me.

donho pushed a commit that referenced this issue Nov 18, 2019
Fix tab dragging issues related to switching off TCS_BUTTONS under multi-line tabs mode (per AngryGamer's suggestions)

Fix #6274, fix #6273, fix #4339, close #6278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants