Regression in 7.8.3: double-clicking a found-result does not work properly if Word-Wrap is ON

[Yaron10]

Steps to reproduce:

Check View -> Word Wrap.
Search for a word in the current document (file A).
Switch to another tab.
Double-click a line in the Find Results window.

Result:
File A is activated, the search-term is selected but the relevant line may not be visible.
IOW, the visible lines do not change.

Probably related to 9387dcd (which is a major improvement in general).

Thank you.

[Yaron10]

@cmeriaux,

Thank you for 9387dcd. 👍

Adding
(*_ppEditView)->_positionRestoreNeeded = false;
before
Searching::displaySectionCentered(fInfo._start, fInfo._end, *_ppEditView);
in FindReplaceDlg.cpp seems to solve the problem.

What do you think?

[cmeriaux]

@Yaron10 Thank you for the encouragements
It seems the issue was already existing in the previous release (7.8.2): the displayed section is not centered in case of word wrap. Can you confirm ?
Could you also do a screencast please ?

[Yaron10]

@cmeriaux,

Prior to 7.8.3 the line containing the search term is indeed not centered.
This should be investigated but it's relatively a minor issue.

In 7.8.3 the line containing the search term is not visible at all.

Open Notepad_plus.cpp (position 0, 0).
Search for pBuf->setUserReadOnly(isStarting);.
Switch to another tab.
Double-click pBuf->setUserReadOnly(isStarting); in the Find Results window.

This is prior to 7.8.3.

And this is 7.8.3.

[cmeriaux]

Thanks @Yaron10 I was able to reproduce and to test with the fix you've give. Thanks
Sorry for the regression

[Yaron10]

@cmeriaux,

Thank you for testing it and submitting the PR.
And thanks again for 9387dcd. I think it's important and useful.