Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Switcher window icons have problems when Tab Bar 'Reduce' setting changed #8109

Closed
sasumner opened this issue Apr 13, 2020 · 1 comment
Closed
Labels

Comments

@sasumner
Copy link
Contributor

sasumner commented Apr 13, 2020

Description of the Issue

When the Preferences > General > Tab Bar > Reduce setting is changed, the icons in the window with title Doc Switcher have display issues, until a Notepad++ restart is done.

Steps to Reproduce the Issue

  1. In Preferences > General, tick the Show box for Document List Panel
  2. Restart Notepad++, observe window called Doc Switcher on lefthand side
    Observe the icons for "new 1" in both the tab bar and the Doc Switcher window
  3. In Preferences > General > Tab Bar, untick the Reduce box
    Observe that tab bar icon for "new 1" tab has increased in size
    Observe that icon for "new 1" in Doc Switcher window has NOT increased in size
  4. Click on the "new 1" text in the Doc Switcher window
    Observe that the available space for the icon has NOT increased, but the icon image HAS increased in side so it is now ILL-FITTING!:
    image
  5. In Preferences > General > Tab Bar, tick the Reduce box
    Observe that tab bar icon for "new 1" tab has decreased in size
    Observe that icon for "new 1" in Doc Switcher window has NOT changed
  6. Click on the "new 1" text in the Doc Switcher window
    Observe that the icon has now DISAPPEARED!:
    image

Expected Behavior

  • After step 4, the available space for the icon becomes enlarged so that the entire non-Reduce'd icon fits.
  • After step 6, the icon doesn't disappear but rather appears and is sized correctly to a Reduce'd icon size.
  • In general, icons to change size in synchrony, and to not disappear of be poorly fit to the available space.

Actual Behavior

See most of the "Observe" comments in the "Steps to Repro" above, especially ones with ALL CAPS and BOLD.

Additional Information

After a restart of Notepad++, all is fine with Reduce 'd icons, if Reduce was ticked at the prior exiting of Notepad++:
image

After a restart of Notepad++, all is fine with non- Reduce 'd icons, if Reduce was unticked at the prior exiting of Notepad++:
image

Debug Information

Notepad++ v7.8.5 (64-bit)
Build time : Mar 4 2020 - 11:08:34
Path : C:.......\npp.7.8.5.bin.x64\notepad++.exe
Admin mode : OFF
Local Conf mode : ON
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 1809
OS Build : 17763.1039
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

@ArkadiuszMichalski
Copy link
Contributor

Same for me (looks like step 2. is unnecessary):

Notepad++ v7.9 (32-bit)
Build time : Sep 22 2020 - 03:24:22
Path : D:_test\NPPClean\notepad++.exe
Admin mode : ON
Local Conf mode : ON
OS Name : Windows 7 Ultimate (64-bit)
OS Build : 7601.0
Current ANSI codepage : 1250
Plugins : none

Another STR (all action in Prefs window, witohut click on Document List Panel):

  1. Turn on Document List Panel.
  2. Turn of Reduce.
  3. Turn off and on Document List Panel.
  4. Trun on Reduce
  5. Turn off and on Document List Panel.

and repeat 2-5.

By the way I also checked Window manager plugin and problem not exist (i.e. resizing the tabs doesn't work in panel, but the icon does not disappear). Additional info for those who still use this plugin.

@sasumner sasumner removed their assignment Jul 6, 2021
@donho donho closed this as completed in 781709a May 29, 2023
molsonkiko pushed a commit to molsonkiko/notepad-plus-plus that referenced this issue Jun 13, 2023
- use one tab icon size
- close button crop in RTL
- improve text positions
- font size adjustment

ref: notepad-plus-plus#13702 (comment)

Fix notepad-plus-plus#10349, fix notepad-plus-plus#8109, close notepad-plus-plus#13709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants