Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please extend the "Browse for Folder" to match path opened #8513

Closed
dylanh724 opened this issue Jul 3, 2020 · 10 comments
Closed

Please extend the "Browse for Folder" to match path opened #8513

dylanh724 opened this issue Jul 3, 2020 · 10 comments
Assignees
@mere-human
Labels
accepted

Comments

@dylanh724
Copy link

Issue:

The "Browse for Folder" is the lazy browser instead of the full one -- I can't drop a path, so as coders that likely have a deep hierarchy, we have to manually find what we're looking for.

Let's say I have a path, but forgot the file name. Paste the path in >> browse >> it goes straight back to the beginning "Desktop, etc" O_o

Solution

Either use a full file browser popup, or allow browse to start from the path input instead of top level.
@sasumner
Copy link
Contributor

sasumner commented Jul 3, 2020

Any particular reason you deleted the new issue template, instead of filling it out?

@sasumner
Copy link
Contributor

sasumner commented Jul 3, 2020 •
edited
Loading

Presume that the user is speaking of the ... button functionality in the Find in Files window:

image

If user had walked us through Steps to Reproduce instead of ignoring that, wouldn't have to presume...

@dylanh724
Copy link
Author

dylanh724 commented Jul 3, 2020 •
edited
Loading

Any particular reason you deleted the new issue template, instead of filling it out?

Probably the same reason you decided to use the ghetto file picker instead of the full one with an address bar and shortcuts, bud. It probably would've been better if I followed the template; I won't skip it next time. (Information overload, though : I'd find a way to parse that down.)

@sasumner
Copy link
Contributor

sasumner commented Jul 3, 2020

Probably the same reason you decided to use the ghetto file picker instead of the full one with an address bar and shortcuts

Not sure I see the correlation between those two things.
Also not sure the meaning of "ghetto" used in this context.
But I think I see your point about the Browse for Folder box being not so good.
I would guess it is a feature not used often by users.

...the template... (Information overload, though : I'd find a way to parse that down.)

The author of Notepad++ is not a native English speaker, and Notepad++ is used around the world and translated into many languages. For this reason, we often get issues filed that are hard to follow/interpret.
The template is designed (well, one reason for it) to try to step-by-step extract information from a user that might be struggling to express themselves in English.

It also attempts to provide a common basis for the writer and the reader by soliciting steps-to-reproduce, even for English speakers.
For example, my interpretation of your issue was just a guess. If you'd have said, "Press Shift+Ctrl+f to invoke Find-in-Files, then press the ... button and notice that the Browse For Folder box..." it would have removed any doubt.

Template also requests version information; that should be the first thing anyone thinks of when submitting an issue.

If you have ideas on streamlining the issue template, we'll certainly take them under consideration.

@dylanh724
Copy link
Author

@sasumner #8517

@sasumner sasumner mentioned this issue Jan 6, 2021
Closed
@mere-human
Copy link
Contributor

I'd like to work on it.

@mere-human
Copy link
Contributor

Description of the Issue

Browse For Folder doesn't support a file path.

Steps to Reproduce the Issue

  1. Open in Notepad++ Menu > Search > Find...
  2. Open Find in Files tab
  3. Click on ... button in Directory section
    image

Expected Behavior

File Open dialog appears similar to File > Open that allows path operations.

Actual Behavior

Browse for Folder dialog doesn't allow editing or pasting the path as text.

image

Debug Information

Notepad++ v7.9.2 (32-bit)
Build time : Dec 31 2020 - 03:58:36
Path : C:\Program Files (x86)\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 2009
OS Build : 19042.685
Current ANSI codepage : 1252
Plugins : ComparePlugin.dll DSpellCheck.dll HexEditor.dll mimeTools.dll NppConverter.dll NppExport.dll

@sasumner
Copy link
Contributor

sasumner commented Jan 8, 2021

@mere-human I assigned you. (Hopefully that doesn't get me in trouble with @donho for doing that) :-)

@donho
Copy link
Member

donho commented Jan 8, 2021

@sasumner

(Hopefully that doesn't get me in trouble with @donho for doing that) :-)

You're doing the right thing.

@mere-human

Expected Behavior
File Open dialog appears similar to File > Open that allows path operations.

So it would be a "Open file dialog" but it opens only the folder?

@sasumner
Copy link
Contributor

sasumner commented Jan 8, 2021

So it would be a "Open file dialog" but it opens only the folder?

The expectation that the result is somewhat similar to the following:

image

@donho donho added the accepted label Jan 8, 2021
mere-human added a commit to mere-human/notepad-plus-plus that referenced this issue Jan 9, 2021
@mere-human
Use new style dialog to browse a folder
0ea0b7b 
Add new methods to CustomFileDialog:
- setTitle() sets the dialog title
- setFolder() sets an initial directory
- pickFolder() shows a file open dialog to select a folder

Use CustomFileDialog in folderBrowser().

Affected areas:
- Search > Find in Files
- File > Open Folder as Workspace
- Preferences > Default Directory
- Preferences > Backup > Custom Backup
- Preferences > Cloud & Link

Fix notepad-plus-plus#8513
mere-human added a commit to mere-human/notepad-plus-plus that referenced this issue Jan 9, 2021
@mere-human
Use new style dialog to browse a folder
323dbbb 
Add new methods to CustomFileDialog:
- setTitle() sets the dialog title
- setFolder() sets an initial directory
- pickFolder() shows a file open dialog to select a folder

Use CustomFileDialog in folderBrowser().

Affected areas:
- Search > Find in Files
- File > Open Folder as Workspace
- Preferences > Default Directory
- Preferences > Backup > Custom Backup
- Preferences > Cloud & Link

Fix notepad-plus-plus#8513
@mere-human mere-human mentioned this issue Jan 9, 2021
Closed
@donho donho closed this as completed in b58a5cc Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mere-human mere-human

Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new style dialog to browse a folder mere-human/notepad-plus-plus
4 participants
@donho @dylanh724 @mere-human @sasumner