Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the download last release part from Appveyor script and use the generated SciLexer.dll #9581

Closed
donho opened this issue Feb 25, 2021 · 2 comments
Closed

Remove the download last release part from Appveyor script and use the generated SciLexer.dll #9581

donho opened this issue Feb 25, 2021 · 2 comments
Assignees
@chcg
Labels
boost regex dependent build / code

Comments

@donho
Copy link
Member

donho commented Feb 25, 2021

Currently in Appveyor build, we download SciLixer.dll from the latest release for Unit tests (of function list especially).
In PR #9574 the boost is included in Appveyor build.

We can remove the download last release part from Appveyor script and use the generated SciLexer.dll, since the PR mentioned above has been committed in the branch master.
@donho donho mentioned this issue Feb 25, 2021
Closed
@donho
Copy link
Member Author

donho commented Feb 25, 2021

@chcg
Could you please remove SUPPORT_XP from the script as well ?

@ArkadiuszMichalski ArkadiuszMichalski mentioned this issue Feb 26, 2021
Closed
chcg added a commit to chcg/notepad-plus-plus that referenced this issue Feb 27, 2021
@chcg
fix for notepad-plus-plus#9581
b6c46ff 
- Remove the download last release part from Appveyor script and use the generated SciLexer.dll
- Could you please remove SUPPORT_XP from the script as well ?
@chcg chcg mentioned this issue Feb 27, 2021
Closed
@chcg
Copy link
Contributor

chcg commented Feb 27, 2021

@ArkadiuszMichalski Your PR #9583 was already the correct fix for the change needed here. I created now #9581.
@donho Did the requested changes.

donho pushed a commit to donho/notepad-plus-plus that referenced this issue Feb 27, 2021
@chcg @donho
Use the generated SciLexer.dll which contains regExpr of Boost
10b091b 
Currently in Appveyor build, we download SciLixer.dll from the latest release for Unit tests (of function list especially).
In PR notepad-plus-plus#9574 the boost is included in Appveyor build.

In this PR:
- Remove the download last release part from Appveyor script and use the generated SciLexer.dll
- Remove SUPPORT_XP from the script

Fix notepad-plus-plus#9581, close notepad-plus-plus#9591
@donho donho closed this as completed in f2f12b2 Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chcg chcg

Labels
boost regex dependent build / code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: use the generated SciLexer.dll which contains regExpr of Boost chcg/notepad-plus-plus
2 participants
@donho @chcg