NPP RTL: Floating panel movement fix

[Ashfaaq18]

fix #10579

tested LTR and RTL, works as expected on both layouts.
Still got to fix the docking of the panels in RTL format, will need to open another issue for it.

[Yaron10]

@Ashfaaq18,

Great work as always. 👍
You're officially the NPP RTL master. :)

Thank you very much.

---

Still got to fix the docking of the panels in RTL format, will need to open another issue for it.

👍

[Ashfaaq18]

Great work as always. 👍
You're officially the NPP RTL master. :)

Haha, Thank you @Yaron10 and @donho for all the support.

[donho]

Thank you both @Yaron10 & @Ashfaaq18 to make RTL great again!

[Yaron10]

The thanks and flowers to @Ashfaaq18.
He has fixed some major RTL issues in a short time. Professional and clever!

"Make RTL Great Again". An interesting paraphrase. :)

[Yaron10]

@Ashfaaq18,

Still got to fix the docking of the panels in RTL format, will need to open another issue for it.

Should I open the issue?

---

OFF-TOPIC:

(I know it's not your code).

notepad-plus-plus/PowerEditor/src/WinControls/VerticalFileSwitcher/VerticalFileSwitcherListView.cpp

Line 155 in d692b50

TaskLstFnStatus *tl = new TaskLstFnStatus(fileNameStatus._iView, fileNameStatus._docIndex, fileNameStatus._fn, fileNameStatus._status, (void *)fileNameStatus._bufID);

notepad-plus-plus/PowerEditor/src/WinControls/VerticalFileSwitcher/VerticalFileSwitcherListView.cpp

Line 311 in d692b50

TaskLstFnStatus *tl = new TaskLstFnStatus(iView, 0, buf->getFullPathName(), 0, (void *)bufferID);

Shouldn't there be delete statements after those new calls?
If positive, I think there are quite a few similar cases throughout NPP code.

Thank you.

[Ashfaaq18]

@Ashfaaq18,

Still got to fix the docking of the panels in RTL format, will need to open another issue for it.

Should I open the issue?

Yeah, sure.

OFF-TOPIC:

(I know it's not your code).

notepad-plus-plus/PowerEditor/src/WinControls/VerticalFileSwitcher/VerticalFileSwitcherListView.cpp

Line 155 in d692b50

TaskLstFnStatus *tl = new TaskLstFnStatus(fileNameStatus._iView, fileNameStatus._docIndex, fileNameStatus._fn, fileNameStatus._status, (void *)fileNameStatus._bufID);

notepad-plus-plus/PowerEditor/src/WinControls/VerticalFileSwitcher/VerticalFileSwitcherListView.cpp

Line 311 in d692b50

TaskLstFnStatus *tl = new TaskLstFnStatus(iView, 0, buf->getFullPathName(), 0, (void *)bufferID);

Shouldn't there be delete statements after those new calls? If positive, I think there are quite a few similar cases throughout NPP code.

Thank you.

I think they do get deleted when the application exits, Its the "delete tlfs" lines in the below 2 code snippets.

This one below is called when the application exits and when a file is closed.

notepad-plus-plus/PowerEditor/src/WinControls/VerticalFileSwitcher/VerticalFileSwitcherListView.cpp

Lines 348 to 357 in d692b50

	void VerticalFileSwitcherListView::remove(int index)
	{
	LVITEM item;
	item.mask = LVIF_PARAM;
	item.iItem = index;
	ListView_GetItem(_hSelf, &item);
	TaskLstFnStatus *tlfs = (TaskLstFnStatus *)item.lParam;
	delete tlfs;
	ListView_DeleteItem(_hSelf, index);
	}

This is called only on application exit

notepad-plus-plus/PowerEditor/src/WinControls/VerticalFileSwitcher/VerticalFileSwitcherListView.cpp

Lines 65 to 79 in d692b50

	void VerticalFileSwitcherListView::destroy()
	{
	LVITEM item;
	item.mask = LVIF_PARAM;
	int nbItem = ListView_GetItemCount(_hSelf);
	for (int i = 0 ; i < nbItem ; ++i)
	{
	item.iItem = i;
	ListView_GetItem(_hSelf, &item);
	TaskLstFnStatus *tlfs = (TaskLstFnStatus *)item.lParam;
	delete tlfs;
	}
	::DestroyWindow(_hSelf);
	_hSelf = NULL;
	}

[Yaron10]

#10641.

---

I think they do get deleted when the application exits...

Great.
Thank you for looking into it and enlightening me. 👍