Show non-printable characters #13020

ozone10 · 2023-02-01T07:52:08Z

fix issue with tooltips in preference dialog, when changing between dark/light mode

defined for:

Codepoint : character : name : abbreviation
U+00A0 :   : no-break space : NBSP
U+1680 :   : ogham space mark : OSPM
U+180E : ᠎ : mongolian vowel separator : MVS
U+2000 :   : en quad : NQSP
U+2001 :   : em quad : MQSP
U+2002 :   : en space : ENSP
U+2003 :   : em space : EMSP
U+2004 :   : three-per-em space : 3/MSP
U+2005 :   : four-per-em space : 4/MSP
U+2006 :   : six-per-em space : 6/MSP
U+2007 :   : figure space : FSP
U+2008 :   : punctation space : PSP
U+2009 :   : thin space : THSP
U+200A :   : hair space : HSP
U+200B :  : zero-width space : ZWSP
U+200C : ‌ : zero-width non-joiner : ZWNJ
U+200D : ‍ : zero-width joiner : ZWJ
U+200E : ‎ : left-to-right mark : LRM
U+200F : ‏ : right-to-left mark : RLM
U+2028 :   : line separator : LS
U+2029 :   : paragraph separator : PS
U+202A : ‪ : left-to-right embedding : LRE
U+202B : ‫ : right-to-left embedding : RLE
U+202C : ‬ : pop directional formatting : PDF
U+202D : ‭ : left-to-right override : LRO
U+202E : ‮ : right-to-left override : RLO
U+202F :   : narrow no-break space : NNBSP
U+205F :   : medium mathematical space : MMSP
U+2060 : ⁠ : word joiner : WJ
U+2066 : ⁦ : left-to-right isolate : LRI
U+2067 : ⁧ : right-to-left isolate : RLI
U+2068 : ⁨ : first strong isolate : FSI
U+2069 : ⁩ : pop directional isolate : PDI
U+206A : ⁪ : inhibit symmetric swapping : ISS
U+206B : ⁫ : activate symmetric swapping : ASS
U+206C : ⁬ : inhibit arabic form shaping : IAFS
U+206D : ⁭ : activate arabic form shaping : AAFS
U+206E : ⁮ : national digit shapes : NADS
U+206F : ⁯ : nominal digit shapes : NODS
U+3000 : 　 : ideographic space : IDSP
U+FEFF :  : zero-width no-break space : ZWNBSP

fix #827
fix #4731
fix #8284

fix issue with tooltips in preference dialog, when changing between dark/light mode

pryrt · 2023-02-01T14:27:45Z

From a UI perspective -- I originally thought those 1, 2, and ? were supposed to be buttons of some sort, and tried clicking them rather than just hovering. And this was even having seen the "fix issue with tooltips" in the PR. So I'm not sure that your average user is going to know to hover rather than click on those. Is there a way to make clicking the box also pop up the hover text?

Also, how critical is it, really, to have that full list in the UI? Would it be better to just put those lists in the User Manual, and just have the Preferences dialog show the Abbreviation and Codepoint radio buttons, without the 1,2,? non-buttons. Maybe have a short hover for each, so Abbreviation has a hover of e.g. NBSP for the no-break space character; see the User Manual for the full list, and Codepoint has a hover of e.g. U+00A0 for the no-break-space character; see the User Manual for the full list.

alankilborn · 2023-02-01T15:27:29Z

Here's someone else's definition of "non-printable": #8111

alankilborn · 2023-02-01T16:11:16Z

I originally thought those 1, 2, and ? were supposed to be buttons of some sort

I endorse @pryrt 's feelings about these buttons, including "is it really needed".

If user clicks one, nothing happens. Worse, after the click attempt, user's mouse points to the button while user waits for something to happen. This causes the tip to NEVER appear (without user moving mouse away and then back into button space).

Yaron10 · 2023-02-01T16:20:53Z

@ozone10,

Thank you for your work. 👍

Toggling the command or changing the preference does not take effect until clicking in the editing area.
Can this be changed?

Yaron10 · 2023-02-01T16:24:20Z

Would it be better to just put those lists in the User Manual, and just have the Preferences dialog show the Abbreviation and Codepoint radio buttons, without the 1,2,? non-buttons.

👍

A link to the User Manual is another option.

ozone10 · 2023-02-01T16:30:18Z

@pryrt, @alankilborn,
thx for feedback.
I did some quick tweaks for GUI could you check it.

@Yaron10

Toggling the command or changing the preference does not take effect until clicking in the editing area. Can this be changed?

I've noticed it too, but I am not sure how to fix it now.

For [?] button I've just copied code. The same issues also affect performance and delimiter [?] buttons.

Yaron10 · 2023-02-01T16:37:15Z

@ozone10,

I've noticed it too, but I am not sure how to fix it now.

A known-issue is legit. :)

ozone10 · 2023-02-01T16:41:47Z

@alankilborn

Here's someone else's definition of "non-printable": #8111

well this PR is more about "non-ASCII" non-printable characters.

pryrt · 2023-02-01T18:01:57Z

The same issues also affect performance and delimiter [?] buttons.

Yes, well, I've never liked those buttons' behavior, either. I've just never felt strongly enough about the other two to put in a separate issue, since I only used those two hover texts once (when trying to figure out what the button was supposed to do). For your button, I was just in the loop early enough to be able to complain about it before it was released ;-)

I did some quick tweaks for GUI could you check it.

I downloaded the x64 release build exe from appveyor, and I definitely prefer the updated Preferences page: the single ? works more as expected: a slow mouse user will see a hover text telling them to click for more details, and a fast mouse user will click that button before the hover and still get all the info. And thanks for adding hover text to the two radio button labels as well. So that commit is a definite improvement on the Preferences side.

alankilborn · 2023-02-01T18:21:35Z

A link to the User Manual is another option.

There's already a link to the user manual in the ? menu.
But I think you mean a (future) direct link to the topic at hand.
The problem with that is that then there becomes a maintenance issue as that link has to live forever.
And someone has to remember that it can't ever be changed.
I'm not saying I'm opposed, but it would be a great disappointment if someday such a link stops working.

alankilborn · 2023-02-01T18:24:21Z

Here's someone else's definition of "non-printable": #8111

well this PR is more about "non-ASCII" non-printable characters.

Hmm, why not make a "complete" solution? Not that I know what that looks like... :-)

alankilborn · 2023-02-01T18:30:32Z

I really don't think Show All Characters is the correct name for showing whitespace+line-endings any longer, with the advent of the new command put forth by this PR. Could this PR adjust that, or would that be a subject for a future issue/PR?

Probably Show White Space and TAB is poorly named as well. As this is done in a different color rather than reverse video like EOL and these new "non-printable" characters, maybe Emphasize U+0020 Whitespace and TAB Characters is better? Or Emphasize Whitespace and TAB Characters? (but that loses something without the U+0020, sigh).

pryrt · 2023-02-01T19:44:32Z

I don't know how I feel about Emphasize. The fact that it's not a reverse-video symbol doesn't change the fact that it is still showing a symbol for the space and tab characters: it might not be the same kind of symbol, but it's still a symbol, and the option does toggle whether or not that symbol is shown.

But more than that, Whitespace and TAB Characters was never an accurate description: "TAB" in all-caps is a holdover from people trying to make the tab character name look like the other ASCII control character abbreviations, though it's official abbreviation is actually HT. (Though I understand that the TAB notation is used throughout the UI, so some might argue it should stay TAB here for consistency, since this PR isn't going to change TAB to Tab throughout the UI. But I'd vote to use Tab here [first-letter capitalized, to match the capitalization of Space here and the capitalization of most other nouns and adjectives in the menu system, and then maybe put in a separate issue/PR to make Tab the consistent usage throughout the UI.)

And the tab character is a Whitespace character, as are newlines and vertical tabs and some of the "non-printable" Unicode characters, so separating "Tab" as somehow distinct from the "Whitespace" or "White Space" is not an accurate separation. Since the only two characters affected by that toggle are the literal space (ASCII 32, U+0020) and the tab (ASCII 9, U+0009), I think that Show Space and Tab is more accurate and understandable.

As for the new name for the never-accurate Show All Characters, how about Show Space, Tab, and End of Line -- that is, just merge the names of the two previous menu entries into the third, multi-use entry.

ozone10 · 2023-02-01T19:51:34Z

@alankilborn

Hmm, why not make a "complete" solution? Not that I know what that looks like... :-)

Because ASCII characters are already visible. This PR is dealing with "invisible" characters.

IMHO I think Show White Space and TAB should be Show Space and Tab and Show All Characters can stay as it currently also enable/disable Show Non-Printable Characters

pryrt · 2023-02-01T20:02:30Z

Show All Characters can stay as it currently also enable/disable Show Non-Printable Characters

Oh, I hadn't noticed that toggling the Show All also forced the new menu entry to toggle.

I'm not sure I like that, because then to move from a current state of Show Space and Tab to the state where it shows space, tab, and newlines, would require first clicking on Show All Characters and then un-clicking Show Non-Printable Characters. For people (like me) who are used to quickly toggling between their two favorite "show symbol" states, requiring us to go back to the menu a second time to change to the state we actually intended would get annoying really quickly.

alankilborn · 2023-02-01T20:05:19Z

Hmm, why not make a "complete" solution? Not that I know what that looks like... :-)

Because ASCII characters are already visible. This PR is dealing with "invisible" characters.

Sure, OK, in the spirit of keeping changes small. Hopefully if someone does a solution for not showing the ASCII characters, it fits in well with this PR's changes.

alankilborn · 2023-02-01T20:08:56Z

Oh, I hadn't noticed that toggling the Show All also forced the new menu entry to toggle.

I hadn't noticed that either.
I guess we had to read the code in order to understand the nuances of how this PR works.

alankilborn · 2023-02-01T21:02:55Z

@ozone10,
Thank you for your work. 👍

This is true. Praise where praise is due.
NICE WORK, @ozone10 !
I hope this gets adopted, perhaps with some slight tweaks.
Again, great job.

Yaron10 · 2023-02-02T01:01:28Z

There's already a link to the user manual in the ? menu.
But I think you mean a (future) direct link to the topic at hand.
The problem with that is that then there becomes a maintenance issue as that link has to live forever.

👍

Oh, I hadn't noticed that toggling the Show All also forced the new menu entry to toggle.
I'm not sure I like that...

👍

pnedev/comparePlus#345 (comment).

See how NPP implements "View -> Show Symbol -> Show White Space and Tab" and "View -> Show Symbol -> Show End of Line".
Checking one command, automatically unchecks the other.
IMO, that behavior is wrong in that case: the two commands are not contradicting whatsoever.
(The third command "Show All Characters" probably made the coder implement it that way).

@ozone10,

Show White Space and TAB and Show End of Line are currently (in Master) Show White Space and TAB ONLY and Show End of Line ONLY.
If you keep the linkage between Show Non-Printable to Show All Characters, checking either Show White Space and TAB or Show End of Line should uncheck Show Non-Printable.

(IMO, Show All Characters should be removed and each command should be independent).

If you use a MsgBox, how about replacing the ? with ...?

I also think that Non-Printable is not the best term.

Thanks again.

alankilborn · 2023-02-02T11:51:23Z

Show All Characters should be removed and each command should be independent

I agree, this would be better than existing implementations, both as currently in released N++, and in this PR.

If you use a MsgBox, how about replacing the ? with ...?

Makes sense.

I also think that Non-Printable is not the best term.

Agree, but your lack of suggesting a substitute shows how difficult coming up with a good substitute is. :-)
Someone else suggested to me "Non-glyphed", which is growing on me...

ozone10 · 2023-02-02T14:40:42Z

Sorry wrong button.

@pryrt

I'm not sure I like that, because then to move from a current state of Show Space and Tab to the state where it shows space, tab, and newlines, would require first clicking on Show All Characters and then un-clicking Show Non-Printable Characters. For people (like me) who are used to quickly toggling between their two favorite "show symbol" states, requiring us to go back to the menu a second time to change to the state we actually intended would get annoying really quickly.

@alankilborn, @Yaron10

Should it be "non-printing or control and whitespace characters"?

https://en.wikipedia.org/wiki/Control_character
https://en.wikipedia.org/wiki/Whitespace_character

Yaron10 · 2023-02-04T00:15:58Z

@ozone10,

May I ask you when npcSync should be no?

Thank you.

pryrt · 2023-02-04T01:58:47Z

@pryrt
In which section we should put this information? Could you provide the URL please?

@donho , it will be in the https://npp-user-manual.org/docs/views/#show-symbol section

@ozone10

New feature in active development per notepad-plus-plus/notepad-plus-plus#13020 Started the documentation now, even though the feature hasn't been committed, because Don wanted to know what the URL would be for the table. The table was populated based on @ozone10's list that was previously shown in dialog box, but with the abbreviations updated based on https://en.wikipedia.org/wiki/List_of_Unicode_characters#General_Punctuation The feature is still in-progress, so the documentation is, too.

donho · 2023-02-04T02:38:58Z

@Yaron10

May I ask you when npcSync should be no?

Well caught.
npcSync is initialized as yes if this argument is absent. It will never be modified except user changes it manually in config.xml.
I suppose it was for GUI "sync with show all" option initially but it's forgotten to be deleted when the GUI option was removed.

donho

Please follow the suggestions.
Add NPC custom color node in bool NppParameters::feedStylerArray(TiXmlNode *node) similar as EOL custom color node (so "NPC custom color" node will be always available, even the styler.xml is not updated):
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/src/Parameters.cpp#L3886

PowerEditor/src/WinControls/ColourPicker/WordStyleDlg.cpp

PowerEditor/src/WinControls/Preference/preferenceDlg.cpp

PowerEditor/src/Parameters.h

PowerEditor/src/WinControls/Preference/preference.rc

handle missing NPC color style in theme files, open User Manual directly to relevant page, tweaks

ozone10 · 2023-02-04T16:04:27Z

@Yaron10

May I ask you when npcSync should be no?

It was supposed to be hidden option for users who don't want change how Show All Characters currently works (show/hide space, tab and EOL).

But unless there is demand for it I have removed it for now.

@donho

So that's the table we should put in https://npp-user-manual.org/ ~~Do you confirm?~~ If it's, could you provide the code in Markdown or HTML please?

This was only for reference. This PR also include other non-printing and whitespace characters.
Table should be based on #13020 (comment)

ozone10 · 2023-02-04T16:24:17Z

@donho

Name	Codepoint	Abbreviation
No-Break Space	U+00A0	NBSP
Ogham Space Mark	U+1680	OSPM
Mongolian Vowel Separator	U+180E	MVS
En Quad	U+2000	NQSP
Em Quad	U+2001	MQSP
En Space	U+2002	ENSP
Em Space	U+2003	EMSP
Three-Per-Em Space	U+2004	3/MSP
Four-Per-Em Space	U+2005	4/MSP
Six-Per-Em Space	U+2006	6/MSP
Figure Space	U+2007	FSP
Punctation Space	U+2008	PSP
Thin Space	U+2009	THSP
Hair Space	U+200A	HSP
Zero-Width Space	U+200B	ZWSP
Zero-Width Non-Joiner	U+200C	ZWNJ
Zero-Width Joiner	U+200D	ZWJ
Left-To-Right Mark	U+200E	LRM
Right-To-Left Mark	U+200F	RLM
Line Separator	U+2028	LS
Paragraph Separator	U+2029	PS
Left-To-Right Embedding	U+202A	LRE
Right-To-Left Embedding	U+202B	RLE
Pop Directional Formatting	U+202C	PDF
Left-To-Right Override	U+202D	LRO
Right-To-Left Override	U+202E	RLO
Narrow No-Break Space	U+202F	NNBSP
Medium Mathematical Space	U+205F	MMSP
Word Joiner	U+2060	WJ
Left-To-Right Isolate	U+2066	LRI
Right-To-Left Isolate	U+2067	RLI
First Strong Isolate	U+2068	FSI
Pop Directional Isolate	U+2069	PDI
Inhibit Symmetric Swapping	U+206A	ISS
Activate Symmetric Swapping	U+206B	ASS
Inhibit Arabic Form Shaping	U+206C	IAFS
Activate Arabic Form Shaping	U+206D	AAFS
National Digit Shapes	U+206E	NADS
Nominal Digit Shapes	U+206F	NODS
Ideographic Space	U+3000	IDSP
Zero-Width No-Break Space	U+FEFF	ZWNBSP

donho · 2023-02-04T17:32:37Z

@ozone10
[xml] Update default themes is failed due to [xml]:
https://ci.appveyor.com/project/donho/notepad-plus-plus/builds/46140254

Could you do a new force push please ?

Yaron10 · 2023-02-04T17:36:36Z

@donho & @ozone10,

npcSync is initialized as yes...

It was supposed to be hidden option...

Thank you both. 👍

ozone10 · 2023-02-04T17:40:15Z

failed due to [xml]

Could you do a new force push please ?

I thought commit with changes only to xml should use [xml] in commit name.

PowerEditor/installer/nativeLang/english.xml

alankilborn · 2023-02-05T14:32:38Z

Can this be made the default setting?:

This is such a valuable new feature, but if it is not on-by-default, 90+% of Notepad++ users won't ever know about it and won't be able to benefit from it (the typical user upgrades all the time, but doesn't read release notes).

Make it on by default, let those that complain figure out or ask how to turn it off (if they want, although turning it off is usually not a smart move).

alankilborn · 2023-02-14T16:31:15Z

@ozone10 @donho

When Show Non-Printing characters is enabled, how should they appear in Search results?

donho · 2023-02-14T16:53:21Z

Hmm... Maybe it's better that Search result' Scintilla sync with settings (only this part).
@alankilborn Could you create an issue for that please?

alankilborn · 2023-02-14T18:45:24Z

Could you create an issue for that please?

@ozone10 's PR made it in before the issue could be created.

ref: notepad-plus-plus#13020 (comment) Close notepad-plus-plus#13128

@ozone10

* Show Non-Printable Characters New feature in active development per notepad-plus-plus/notepad-plus-plus#13020 Started the documentation now, even though the feature hasn't been committed, because Don wanted to know what the URL would be for the table. The table was populated based on @ozone10's list that was previously shown in dialog box, but with the abbreviations updated based on https://en.wikipedia.org/wiki/List_of_Unicode_characters#General_Punctuation The feature is still in-progress, so the documentation is, too. * Non-Printing Chars: make the table collapsible * update Table of Non-Printing Characters regenerate table from https://github.com/notepad-plus-plus/notepad-plus-plus/pull/13063/files * restore table header accidentally deleted the header in the previous commit * added v8.5 and clarified

Show non-printable characters

d38a933

fix issue with tooltips in preference dialog, when changing between dark/light mode

GUI tweaks

34706aa

ozone10 force-pushed the NonPrintChars branch from 7ba7da3 to 34706aa Compare February 1, 2023 16:36

pryrt mentioned this pull request Feb 1, 2023

Preferences ? buttons #13024

Open

Remove icon from MsgBox to remove annoying beep

a173d96

chcg added the feature Feature requests and Feature commits label Feb 1, 2023

ozone10 force-pushed the NonPrintChars branch from d021c36 to f994e45 Compare February 2, 2023 14:30

ozone10 closed this Feb 2, 2023

ozone10 reopened this Feb 2, 2023

donho requested changes Feb 4, 2023

View reviewed changes

PowerEditor/src/WinControls/ColourPicker/WordStyleDlg.cpp Outdated Show resolved Hide resolved

PowerEditor/src/WinControls/Preference/preferenceDlg.cpp Outdated Show resolved Hide resolved

PowerEditor/src/Parameters.h Outdated Show resolved Hide resolved

donho reviewed Feb 4, 2023

View reviewed changes

PowerEditor/src/WinControls/Preference/preference.rc Outdated Show resolved Hide resolved

Remove sync completely,

5e8e4e0

handle missing NPC color style in theme files, open User Manual directly to relevant page, tweaks

ozone10 requested a review from donho February 4, 2023 16:25

Update default themes

e062c53

ozone10 force-pushed the NonPrintChars branch from 042fbc0 to e062c53 Compare February 4, 2023 17:34

Yaron10 reviewed Feb 4, 2023

View reviewed changes

PowerEditor/installer/nativeLang/english.xml Outdated Show resolved Hide resolved

Update english.xml

b3bc628

donho approved these changes Feb 5, 2023

View reviewed changes

donho closed this in aaab190 Feb 5, 2023

ozone10 deleted the NonPrintChars branch February 5, 2023 08:22

ozone10 mentioned this pull request Feb 6, 2023

Make NPC show by default #13063

Closed

ozone10 mentioned this pull request Feb 14, 2023

Add support for non-printing char in main Search Result dock window #13128

Closed

pryrt mentioned this pull request Feb 14, 2023

Show non-printable characters notepad-plus-plus/npp-usermanual#477

Closed

donho pushed a commit to donho/notepad-plus-plus that referenced this pull request Feb 20, 2023

Add support for non-printing char in main Search Result dock window

d30b789

ref: notepad-plus-plus#13020 (comment) Close notepad-plus-plus#13128

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show non-printable characters #13020

Show non-printable characters #13020

ozone10 commented Feb 1, 2023 •

edited

Loading

pryrt commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

Yaron10 commented Feb 1, 2023

Yaron10 commented Feb 1, 2023

ozone10 commented Feb 1, 2023 •

edited

Loading

Yaron10 commented Feb 1, 2023

ozone10 commented Feb 1, 2023

pryrt commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023 •

edited

Loading

pryrt commented Feb 1, 2023

ozone10 commented Feb 1, 2023

pryrt commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

Yaron10 commented Feb 2, 2023

alankilborn commented Feb 2, 2023

ozone10 commented Feb 2, 2023

Yaron10 commented Feb 4, 2023

pryrt commented Feb 4, 2023

donho commented Feb 4, 2023 •

edited

Loading

donho left a comment

ozone10 commented Feb 4, 2023

ozone10 commented Feb 4, 2023

donho commented Feb 4, 2023

Yaron10 commented Feb 4, 2023

ozone10 commented Feb 4, 2023

alankilborn commented Feb 5, 2023

alankilborn commented Feb 14, 2023

donho commented Feb 14, 2023 •

edited

Loading

alankilborn commented Feb 14, 2023

Show non-printable characters #13020

Show non-printable characters #13020

Conversation

ozone10 commented Feb 1, 2023 • edited Loading

pryrt commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

Yaron10 commented Feb 1, 2023

Yaron10 commented Feb 1, 2023

ozone10 commented Feb 1, 2023 • edited Loading

Yaron10 commented Feb 1, 2023

ozone10 commented Feb 1, 2023

pryrt commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023 • edited Loading

pryrt commented Feb 1, 2023

ozone10 commented Feb 1, 2023

pryrt commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

alankilborn commented Feb 1, 2023

Yaron10 commented Feb 2, 2023

alankilborn commented Feb 2, 2023

ozone10 commented Feb 2, 2023

Yaron10 commented Feb 4, 2023

pryrt commented Feb 4, 2023

donho commented Feb 4, 2023 • edited Loading

donho left a comment

Choose a reason for hiding this comment

ozone10 commented Feb 4, 2023

ozone10 commented Feb 4, 2023

donho commented Feb 4, 2023

Yaron10 commented Feb 4, 2023

ozone10 commented Feb 4, 2023

alankilborn commented Feb 5, 2023

alankilborn commented Feb 14, 2023

donho commented Feb 14, 2023 • edited Loading

alankilborn commented Feb 14, 2023

ozone10 commented Feb 1, 2023 •

edited

Loading

ozone10 commented Feb 1, 2023 •

edited

Loading

alankilborn commented Feb 1, 2023 •

edited

Loading

donho commented Feb 4, 2023 •

edited

Loading

donho commented Feb 14, 2023 •

edited

Loading