Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BeginEnd Select in Column Mode command #13034

Closed
wants to merge 2 commits into from

Conversation

alankilborn
Copy link
Contributor

Fix #12833
Fix #12832

@chcg chcg added the enhancement Proposed enhancements of existing features label Feb 2, 2023
@Yaron10
Copy link

Yaron10 commented Feb 2, 2023

@alankilborn,

Thank you for your work. 👍 :)

@Yaron10
Copy link

Yaron10 commented Feb 3, 2023

@alankilborn,

Shouldn't you modify some values in localization.cpp?

If you use the old localization files, the menu is messed up.

תמונה

תמונה

Thank you.

@donho
Copy link
Member

donho commented Feb 3, 2023

@Yaron10

Shouldn't you modify some values in localization.cpp?

In the old system (long time ago) adding a new menu item need to modify the localization files - but it was not reasonable because once we changed the menu structures we have had to modify near 100 localization files.

Now adding a (or several) new menu item(s) should just adjust the map in the source code so the translation keeps working without touching any localization file.

@alankilborn
You should look at here:
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/src/localization.cpp#L28

@Yaron10
Copy link

Yaron10 commented Feb 3, 2023

@donho,

I've suggested to modify localization.cpp. Not the XML localization files.

@alankilborn
Copy link
Contributor Author

@Yaron10 @donho

Thanks for the hint about localization.cpp !

I had no idea that this type of change was necessary.

I made the change and tested the submenus below my new command on the Edit menu.

@Yaron10
Copy link

Yaron10 commented Feb 3, 2023

@alankilborn,

Great! 👍

Thanks again.

@donho donho self-assigned this Feb 3, 2023
@donho
Copy link
Member

donho commented Feb 3, 2023

@donho,

I've suggested to modify localization.cpp. Not the XML localization files.

Oups! Sorry my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement Proposed enhancements of existing features
Projects
None yet
4 participants