Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing items in word autocomplete #13062

Closed
wants to merge 1 commit into from

Conversation

mpheath
Copy link
Contributor

@mpheath mpheath commented Feb 6, 2023

Fix #13060

Word autocomplete change from case sensitive search to variable search based on _ignoreCase unless language type is text. This allows text documents to retain case sensitive search to respect typed case as the issue only affects case insensitive Data/Programming languages. If normal.xml exist in the autocomplete folder then xml defaults apply for text so would be case insensitive by default unless overridden by the xml setting <Environment ignoreCase="no" />.

If full variable search based on _ignoreCase is considered more suitable by including text, then a change is possible.

@chcg chcg added the enhancement Proposed enhancements of existing features label Feb 6, 2023
@donho donho self-assigned this Feb 7, 2023
Copy link
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is !_funcCompletionActive condition necessary?

@mpheath mpheath requested a review from donho February 7, 2023 08:39
@donho donho added the accepted label Feb 7, 2023
@donho donho closed this in 9285bf2 Feb 7, 2023
@mpheath mpheath deleted the autoc_13060 branch February 7, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement Proposed enhancements of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing items in word autocomplete
3 participants