Fix DELETE key not working in multi-editing #14359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CennoxX @vinsworldcom |
|
It seems to fix the Del and Backspace issue for me! You are a rock star! Cheers. |
|
Hi @donho, this does work at the line end with delete, but it doesn't work for backspace at the line start, if I use alt and the curser to drag a multi cursor at the beginning of a line. This only works, if I pressed enter before, or if the cursors were set with ctrl and individual clicks. |
donho
added a commit
that referenced
this pull request
Nov 18, 2023
|
It's working. |
chcg
reviewed
Dec 28, 2023
| else // posStart == posEnd) | ||
| { | ||
| char eolStr[3]; | ||
| Sci_TextRange tr; |
There was a problem hiding this comment.
@donho Shouldn't be Sci_TextRangeFull used instead of deprecated Sci_TextRange? Together with the corresponding SCI_GETTEXTRANGEFULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14338 (comment)