Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting in column mode also delete an unexpected EOL #14536

Conversation

donho
Copy link
Member

@donho donho commented Dec 31, 2023

Fix #14426

@mkupper
Copy link

mkupper commented Jan 1, 2024

@donho, Starting from https://github.com/notepad-plus-plus/notepad-plus-plus I can't figure out where the most recently built but not yet released installer.exe and portable.zip/7z are.

@alankilborn
Copy link
Contributor

@mkupper
All you get is an .exe.
For this case, grab it here: https://github.com/notepad-plus-plus/notepad-plus-plus/actions/runs/7372306928

@mkupper
Copy link

mkupper commented Jan 1, 2024

Thank you @alankilborn - I downloaded and am using

Notepad++ v8.6   (64-bit)
Build time : Dec 31 2023 - 19:18:45

Column delete and the end of line issue has been fixed. Thank you!

@donho - I noticed the version number in debug info is v8.6. I would have expected v8.6.1

The v8.6.1 release candidates show v8.6.1 in their debug info.

@alankilborn
Copy link
Contributor

I noticed the version number in debug info is v8.6. I would have expected v8.6.1

As 8.6.1 hasn't been released yet (just in the release-candidate stage), I'd say 8.6 is what is expected.
But, "build time" should be accurate and can be used to tell where one .exe differs from another (if you lose track).

When I grab such an .exe for testing, I usually rename it to notepad++_PRxxxxx.exe where xxxxx is the pull-request number. It helps me keep track of what I'm looking at, if I "go away and come back later" from something.

@chcg chcg added the bug label Jan 1, 2024
@donho donho closed this in dc6f6d1 Jan 3, 2024
@donho donho deleted the fix_column_mode_delete_unexpected_eol branch February 19, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v 8.6 column delete also deleted an unexpected end-of-lines
4 participants