Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to Scintilla 5.4.2 & Lexilla 5.3.1 #14834

Closed
wants to merge 2 commits into from
Closed

Updated to Scintilla 5.4.2 & Lexilla 5.3.1 #14834

wants to merge 2 commits into from

Conversation

chcg
Copy link
Contributor

@chcg chcg commented Mar 6, 2024 •
edited

Added Release 5.4.3

Released 9 March 2024.
Fix redo failure introduced with 5.4.2. [Bug #2432](https://sourceforge.net/p/scintilla/bugs/2432/).
Add SC_AUTOCOMPLETE_SELECT_FIRST_ITEM option to always selects the first item in the autocompletion list. [Bug #2403](https://sourceforge.net/p/scintilla/bugs/2403/).

https://www.scintilla.org/scintilla542.zip
Release 5.4.2

Released 5 March 2024.
Significantly reduce memory used for undo actions, often to a half or quarter of previous versions. Feature #1458.
Add APIs for saving and restoring undo history.
For GTK, when laying out text, detect runs with both left-to-right and right-to-left ranges and divide into an ASCII prefix and more complex suffix. Lay out the ASCII prefix in the standard manner but, for the suffix, measure the whole width and spread that over the suffix bytes. This produces more usable results where the caret moves over the ASCII prefix correctly and over the suffix reasonably but not accurately.
For ScintillaEdit on Qt, fix reference from ScintillaDocument to Document to match change in 5.4.1 using IDocumentEditable for SCI_GETDOCPOINTER and SCI_SETDOCPOINTER.
For Direct2D on Win32, use the multi-threaded option to avoid crashes when Scintilla instances created on different threads. There may be more problems with this scenario so it should be avoided. Bug #2420.
For Win32, ensure keyboard-initiated context menu appears in multi-screen situations.

https://www.scintilla.org/lexilla531.zip
Release 5.3.1

Released 5 March 2024.
Assembler: After comments, treat \r\n line ends the same as \n. This makes testing easier.
Bash: Fix folding when line changed to/from comment and previous line is comment. Issue #224.
Batch: Fix handling ':' next to keywords. Issue #222.
JavaScript: in cpp lexer, add lexer.cpp.backquoted.strings=2 mode to treat ` back-quoted strings as template literals which allow embedded ${expressions}. Issue #94.
Python: fix lexing of rb'' and rf'' strings. Issue #223, Pull request #227.
Ruby: fix lexing of methods on numeric literals like '3.times' so the '.' and method name do not appear in numeric style. Issue #225.

@chcg
Updated to Scintilla 5.4.2 & Lexilla 5.3.1
f6464b2 
https://www.scintilla.org/scintilla542.zip
Release 5.4.2

    Released 5 March 2024.
    Significantly reduce memory used for undo actions, often to a half or quarter of previous versions. Feature notepad-plus-plus#1458.
    Add APIs for saving and restoring undo history.
    For GTK, when laying out text, detect runs with both left-to-right and right-to-left ranges and divide into an ASCII prefix and more complex suffix. Lay out the ASCII prefix in the standard manner but, for the suffix, measure the whole width and spread that over the suffix bytes. This produces more usable results where the caret moves over the ASCII prefix correctly and over the suffix reasonably but not accurately.
    For ScintillaEdit on Qt, fix reference from ScintillaDocument to Document to match change in 5.4.1 using IDocumentEditable for SCI_GETDOCPOINTER and SCI_SETDOCPOINTER.
    For Direct2D on Win32, use the multi-threaded option to avoid crashes when Scintilla instances created on different threads. There may be more problems with this scenario so it should be avoided. Bug notepad-plus-plus#2420.
    For Win32, ensure keyboard-initiated context menu appears in multi-screen situations.

https://www.scintilla.org/lexilla531.zip
Release 5.3.1

    Released 5 March 2024.
    Assembler: After comments, treat \r\n line ends the same as \n. This makes testing easier.
    Bash: Fix folding when line changed to/from comment and previous line is comment. Issue notepad-plus-plus#224.
    Batch: Fix handling ':' next to keywords. Issue notepad-plus-plus#222.
    JavaScript: in cpp lexer, add lexer.cpp.backquoted.strings=2 mode to treat ` back-quoted strings as template literals which allow embedded ${expressions}. Issue notepad-plus-plus#94.
    Python: fix lexing of rb'' and rf'' strings. Issue notepad-plus-plus#223, Pull request notepad-plus-plus#227.
    Ruby: fix lexing of methods on numeric literals like '3.times' so the '.' and method name do not appear in numeric style. Issue notepad-plus-plus#225.
@mpheath
Copy link
Contributor

mpheath commented Mar 7, 2024 •
edited

Looks like Notepad++ and Scintilla committed code are competing with the same Scintilla context menu (originally handled by Scintilla).

Notepad++: Fix context menu popup location issue

Scintilla: For Win32, ensure keyboard-initiated context menu appears in multi-screen situations

I now see _mainEditView.execute(SCI_USEPOPUP, FALSE) being used in Notepad++ source, so perhaps Notepad++ code is needed for nppParam.hasCustomContextMenu() .

@chcg chcg added scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes lexilla dependent Can't be considered for N++ implementation unless/until Lexiilla changes labels Mar 8, 2024
@donho donho self-assigned this Mar 8, 2024
@alankilborn
Copy link
Contributor

Looks like Notepad++ and Scintilla committed code are competing...

Notepad++ has "always" handled this popup menu, so I don't think there is any "competition"...

@rdipardo
Copy link
Contributor

rdipardo commented Mar 9, 2024

JavaScript: in cpp lexer, add lexer.cpp.backquoted.strings=2 mode to treat ` back-quoted strings as template literals which allow embedded ${expressions}.

To benefit from this, N++ has to configure lexer.cpp.backquoted.strings and provide a new <WordsStyle name="STRING RAW" styleID="20" .... /> for C++.

All that just to close #14539 and a long list of duplicates going back long before VS Code became the JavaScript IDE du jour.

Is it even worth the bother?

@chcg
update to scintilla 5.4.3
564ae0c 
https://www.scintilla.org/scintilla543.zip
Release 5.4.3

    Released 9 March 2024.
    Fix redo failure introduced with 5.4.2. Bug notepad-plus-plus#2432.
    Add SC_AUTOCOMPLETE_SELECT_FIRST_ITEM option to always selects the first item in the autocompletion list. Bug notepad-plus-plus#2403.
@donho donho added the accepted label Mar 11, 2024
@donho donho closed this in 1c32e29 Mar 11, 2024
@chcg chcg deleted the scintilla_542 branch March 11, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@donho donho

Labels
accepted lexilla dependent Can't be considered for N++ implementation unless/until Lexiilla changes scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chcg @mpheath @alankilborn @rdipardo @donho