Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'change history' styles to Style Configurator for theme without them #14905

Closed

Conversation

ozone10
Copy link
Contributor

@ozone10 ozone10 commented Mar 26, 2024

ref #14883

@ozone10
Copy link
Contributor Author

ozone10 commented Mar 26, 2024

Splitted from #14883.

also check

void ScintillaEditView::performGlobalStyles()

for other 'default' styles

@donho
I've noticed little inconsistency, colors from

void ScintillaEditView::performGlobalStyles()

for eol and npc are not same, DADADA and liteGrey (C0C0C0)

@chcg chcg added enhancement Proposed enhancements of existing features theme theming related issues labels Mar 26, 2024
@donho donho self-assigned this Mar 27, 2024
@donho
Copy link
Member

donho commented Mar 27, 2024

@ozone10

I've noticed little inconsistency, colors from
...
for eol and npc are not same, DADADA and liteGrey (C0C0C0)

Why should NPC & EOL should be the same color?

Copy link
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why NPC should use "White space symbol"'s colors ?

addStyle(L"Change History saved", L"00A000", L"00A000");

addStyle(L"EOL custom color", L"DADADA");
addStyle(g_npcStyleName, L"DADADA", L"", L"White space symbol");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why NPC should sync with "White space symbol" ?

Copy link
Contributor Author

@ozone10 ozone10 Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was from previous commit and themes usually already have white space symbol style defined and NPC are mostly some kind of "unicode spaces", so they use same default color

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. Sorry for not seeing it.

@ozone10
Copy link
Contributor Author

ozone10 commented Mar 27, 2024

@donho

Why should NPC & EOL should be the same color?

They already have same colors, just in



they use liteGrey which is C0C0C0
but in
eolColorkNode->ToElement()->SetAttribute(TEXT("fgColor"), TEXT("DADADA"));

npcColorkNode->ToElement()->SetAttribute(L"fgColor", L"DADADA");

they use DADADA

this is from previous commits.

I added lambda function to not repeat code and make it easier to add future 'default' styles.
And used this lambda function for previous EOL and NPC styles.

@donho donho added the accepted label Mar 27, 2024
@donho donho closed this in 30f48aa Mar 27, 2024
@ozone10 ozone10 deleted the DefaultMissStyleConf branch March 27, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement Proposed enhancements of existing features theme theming related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants