New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'change history' styles to Style Configurator for theme without them #14905
Conversation
Why should NPC & EOL should be the same color? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why NPC should use "White space symbol"'s colors ?
addStyle(L"Change History saved", L"00A000", L"00A000"); | ||
|
||
addStyle(L"EOL custom color", L"DADADA"); | ||
addStyle(g_npcStyleName, L"DADADA", L"", L"White space symbol"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why NPC should sync with "White space symbol" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was from previous commit and themes usually already have white space symbol style defined and NPC are mostly some kind of "unicode spaces", so they use same default color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right. Sorry for not seeing it.
They already have same colors, just in
they use liteGrey which is C0C0C0 but in notepad-plus-plus/PowerEditor/src/Parameters.cpp Line 4164 in b31e7a3
notepad-plus-plus/PowerEditor/src/Parameters.cpp Line 4187 in b31e7a3
they use DADADA
this is from previous commits. I added lambda function to not repeat code and make it easier to add future 'default' styles. |
ref #14883