New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ada Function List improvements #14986
Ada Function List improvements #14986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a link to the ADA version or simply/just the ADA version this complies to?
\s+(?&VALID_ID) | ||
(?:(?&PARAMETERS))? # Boost::Regex 1.58-1.59 do not correctly handle quantifiers on subroutine calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the comment no longer apply to the Boost::Regex version that is currently used?
When it still applies, undo the change and update the version of Boost::Regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find a mention of it being fixed in the changelog
But from the tests I've done, it no longer applies, therefore I removed it and simplified the expression.
This PR should include updated unit tests: notepad-plus-plus/CONTRIBUTING.md Line 33 in e0bb723
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Repeat @rdipardo has said)
This PR should include updated unit tests:
notepad-plus-plus/CONTRIBUTING.md
Line 33 in e0bb723
8. The PR for the enhancement of Function List parser should also include unit test. Please refer [here](https://npp-user-manual.org/docs/function-list/#contribute-your-new-or-enhanced-parser-rule-to-the-notepad-codebase) for more information. |
Changes which might be tested via extended unittest file: |
I tested this change and it appears to work for my current project. Edit: I spoke too soon. See below |
@ronww |
-- This was not listed -- This function appears in the function list: -- But this function does not: |
Just discovered that functions/procedure specifications and definitions with comments in the parameter list fail to show in the Function List Example: If the comments in the parameter list are removed, then the procedure is shown. |
@ronww |
All of these should work, but some still do not work function Get_Idle function Get_Phase function Get_State procedure Update; function Int32_To_Byte_Array is function Int8_To_U8 is new Unchecked_Conversion function Int32toInt8TwosComplement (value : Vt.Int32) return Vt.Int8 is function AproxU8 (n : Vt.U8; x : Vt.U8) return Boolean is function Read_I32 (Register : Vt.Address_Range) return Vt.Int_32 is procedure Test_Get_Register( |
@ronww |
Fix #14908 #14687 #14498
Changes:
Ada is case insensitive
Added 'Parallel' reserved word
Identifiers may not begin or end with underscore
Support for identifiers containing digits
Support for Ada specifications file (subprogram declaration) (#14687)
Support for dot notation within types (#14908)
Support for generic instantiations (#14498) (functions with no return statement)