Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to scintilla 5.5.0 & Lexilla 5.3.2 #15042

Closed
wants to merge 1 commit into from

Conversation

chcg
Copy link
Contributor

@chcg chcg commented Apr 24, 2024

Sintilla Release 5.5.0 (https://www.scintilla.org/scintilla550.zip)

Released 23 April 2024.
Add elements for inactive additional selections SC_ELEMENT_SELECTION_INACTIVE_ADDITIONAL_TEXT and SC_ELEMENT_SELECTION_INACTIVE_ADDITIONAL_BACK. When not set these default to SC_ELEMENT_SELECTION_INACTIVE_TEXT and SC_ELEMENT_SELECTION_INACTIVE_BACK. Bug #2417.
On Cocoa, avoid use of NSUserDefaults which will soon require justification when used in applications on the App Store.
Fix Win32 IME crash in windowed mode. Bug #2433.
Scale reverse arrow cursor for margins to match other cursors when user changes pointer size. Bug #2321.

Lexilla Release 5.3.2 (https://www.scintilla.org/lexilla532.zip)

Released 23 April 2024.
COBOL: Stop string literal continuing over line end. Issue #229.
COBOL: Stop doc comment assigning different styles to \r and \n at line end. Issue #229.
COBOL: Recognize keywords that start with 'V'. Issue #230.
COBOL: Recognize comments after tag or that start with '/'. Issue #231.
HTML: Implement substyles for tags, attributes, and identifiers SCE_H_TAG, SCE_H_ATTRIBUTE, SCE_HJ_WORD, SCE_HJA_WORD, SCE_HB_WORD, SCE_HP_WORD, SCE_HPHP_WORD.
HTML: Implement context-sensitive attributes. "tag.attribute" matches "attribute" only inside "tag".
HTML: Match standard handling of comments. Issue #232.
Lua: Implement substyles for identifiers SCE_LUA_IDENTIFIER.
Ruby: Allow non-ASCII here-doc delimiters. Issue #234.
Ruby: Allow modifier if, unless, while and until after heredoc delimiter. Issue #236.
Rust: Recognize raw identifiers. Issue #239, Pull request #240.

Sintilla Release 5.5.0 (https://www.scintilla.org/scintilla550.zip)

    Released 23 April 2024.
    Add elements for inactive additional selections SC_ELEMENT_SELECTION_INACTIVE_ADDITIONAL_TEXT and SC_ELEMENT_SELECTION_INACTIVE_ADDITIONAL_BACK. When not set these default to SC_ELEMENT_SELECTION_INACTIVE_TEXT and SC_ELEMENT_SELECTION_INACTIVE_BACK. Bug notepad-plus-plus#2417.
    On Cocoa, avoid use of NSUserDefaults which will soon require justification when used in applications on the App Store.
    Fix Win32 IME crash in windowed mode. Bug notepad-plus-plus#2433.
    Scale reverse arrow cursor for margins to match other cursors when user changes pointer size. Bug notepad-plus-plus#2321.

Lexilla Release 5.3.2 (https://www.scintilla.org/lexilla532.zip)

    Released 23 April 2024.
    COBOL: Stop string literal continuing over line end. Issue notepad-plus-plus#229.
    COBOL: Stop doc comment assigning different styles to \r and \n at line end. Issue notepad-plus-plus#229.
    COBOL: Recognize keywords that start with 'V'. Issue notepad-plus-plus#230.
    COBOL: Recognize comments after tag or that start with '/'. Issue notepad-plus-plus#231.
    HTML: Implement substyles for tags, attributes, and identifiers SCE_H_TAG, SCE_H_ATTRIBUTE, SCE_HJ_WORD, SCE_HJA_WORD, SCE_HB_WORD, SCE_HP_WORD, SCE_HPHP_WORD.
    HTML: Implement context-sensitive attributes. "tag.attribute" matches "attribute" only inside "tag".
    HTML: Match standard handling of comments. Issue notepad-plus-plus#232.
    Lua: Implement substyles for identifiers SCE_LUA_IDENTIFIER.
    Ruby: Allow non-ASCII here-doc delimiters. Issue notepad-plus-plus#234.
    Ruby: Allow modifier if, unless, while and until after heredoc delimiter. Issue notepad-plus-plus#236.
    Rust: Recognize raw identifiers. Issue notepad-plus-plus#239, Pull request notepad-plus-plus#240.
@chcg
Copy link
Contributor Author

chcg commented Apr 24, 2024

@donho @ArkadiuszMichalski

With this update all files are opened and autodetected as language Go but could be manually changed to the correct one. Need to be investigated. Any hint appreciated.

@chcg chcg marked this pull request as draft April 24, 2024 17:28
@donho donho self-assigned this Apr 24, 2024
@chcg
Copy link
Contributor Author

chcg commented Apr 24, 2024

Just happens if file is opened via context menu and therefore WM_COPYDATA with COPYDATA_PARAMS is used at Notepad_plus::process()

@ozone10
Copy link
Contributor

ozone10 commented Apr 24, 2024

Maybe related to similar issues with JSON5 #13746 and #13042

@chcg
Copy link
Contributor Author

chcg commented Apr 24, 2024

@ozone10 Could be. I'm testing with a portable version 8.5.6 updated with this compilation but there is also an installation of N++ 8.5.6 available. And as raku and go are newly added that might explain this problems.

After replacing the installed N++ file opening via context menu is working as expected again.

@chcg chcg marked this pull request as ready for review April 26, 2024 06:37
@chcg chcg changed the title [WIP] Update to scintilla 5.5.0 & Lexilla 5.3.2 Update to scintilla 5.5.0 & Lexilla 5.3.2 Apr 26, 2024
@donho
Copy link
Member

donho commented Apr 30, 2024

With this update all files are opened and autodetected as language Go but could be manually changed to the correct one. Need to be investigated. Any hint appreciated.

It can happen when the arguments are passed by %ProgramFiles%\Notepad++\notepad++.exe to (YOUR LAUNCHED) whereever\notepad++.exe and both notepad++.exe are not the same version.
Here is the detailed explanation:
#13042 (comment)

@donho donho added the accepted label Apr 30, 2024
@donho donho closed this in 881e8c2 Apr 30, 2024
@chcg chcg deleted the scintillla_550 branch May 1, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants