Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FunctionList Update #1 - normalize functionList.xml #2335

Closed

Conversation

MAPJe71
Copy link
Contributor

@MAPJe71 MAPJe71 commented Sep 25, 2016

  • Updated file header and associationMap-header.
    1. Doubled up the language ID table to make it easier to find the applicable ID value for a known name and vise versa;
    2. Latest LangType table;
  • Changed order of associations and parsers to follow ascending 'langID' numerical values.
  • Removed displayMode attributes (are not used).
  • Make functionList.xml XML compliant.
  • Put set of characters in same order in all character groups.
  • Correct )/ to /) in commentExpr-attribute.
  • Add pattern modifier to multi-line comment expression.
  • Add pattern modifier to single-line comment expression.
  • When applicable remove outer most parentheses of commentExpr-attribute.
  • As an underscore is part of character class \w (equals group [A-Za-z0-9_]) remove the underscore when both are used in the same group.
  • Replace the A-Za-z0-9_ set in a group with character class \w as they are equal.
  • No need to put one character class in a group e.g. change [\w] to \w.
  • Replace space character with its hexdecimal representation i.e. \x20.
  • Corrected Python parser i.e. renamed funcNameExpr to nameExpr in function-parser part.
  • Changed use of L_JS (19) to L_JAVASCRIPT (58).

This PR replaces PR #2233.

- Updated file header and `associationMap`-header.
- Changed order of associations and parsers to follow ascending 'langID' numerical values.
- Removed `displayMode` attributes (are not used).
- Make functionList.xml XML compliant.
- Put set of characters in same order in all character groups.
- Correct `)/` to `/)` in `commentExpr`-attribute.
- Add pattern modifier to multi-line comment expression.
- Add pattern modifier to single-line comment expression.
- When applicable remove outer most parentheses of `commentExpr`-attribute.
- As an underscore is part of character class `\w` (equals group `[A-Za-z0-9_]`) remove the underscore when both are used in the same group.
- Replace the `A-Za-z0-9_` set in a group with character class `\w` as they are equal.
- No need to put one character class in a group e.g. change `[\w]` to `\w`.
- Replace space character with its hexdecimal representation i.e. \x20.
- Corrected Python parser i.e. renamed `funcNameExpr` to `nameExpr` in function-parser part.
- Changed use of L_JS (19) to L_JAVASCRIPT (58).
@donho donho added the accepted label Sep 28, 2016
@donho donho added this to the 7.x (master) milestone Sep 28, 2016
@donho donho self-assigned this Sep 28, 2016
@donho donho closed this in 5d438aa Oct 7, 2016
@MAPJe71 MAPJe71 deleted the FunctionList-Update1 branch October 7, 2016 22:54
SinghRajenM pushed a commit to SinghRajenM/notepad-plus-plus that referenced this pull request Nov 13, 2016
- Updated file header and `associationMap`-header.
- Changed order of associations and parsers to follow ascending 'langID' numerical values.
- Removed `displayMode` attributes (are not used).
- Make functionList.xml XML compliant.
- Put set of characters in same order in all character groups.
- Correct `)/` to `/)` in `commentExpr`-attribute.
- Add pattern modifier to multi-line comment expression.
- Add pattern modifier to single-line comment expression.
- When applicable remove outer most parentheses of `commentExpr`-attribute.
- As an underscore is part of character class `\w` (equals group `[A-Za-z0-9_]`) remove the underscore when both are used in the same group.
- Replace the `A-Za-z0-9_` set in a group with character class `\w` as they are equal.
- No need to put one character class in a group e.g. change `[\w]` to `\w`.
- Replace space character with its hexdecimal representation i.e. \x20.
- Corrected Python parser i.e. renamed `funcNameExpr` to `nameExpr` in function-parser part.
- Changed use of L_JS (19) to L_JAVASCRIPT (58).

Closes notepad-plus-plus#2335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants