Quick find functionality #2383

MojaveWastelander · 2016-10-03T13:26:31Z

Added 'quick find' functionality to search dialog.
Enabled by default, not saved in settings.
When search dialog is opened writing something in search box will search and mark all matches in current document.
Toggling any control on search tab will reset the search, as well as changing search combo box selection.
When search dialog is closed all marks are removed.

…atches when search dialog us hidden.

Marks are cleared always before trying to find a match.

cmeriaux · 2016-10-03T18:15:56Z

Hello, I tested with the nightlibuid
1553095 is OK
966ef61 is KO. Bookmark are always affected.
Like I said before, you should also add "quick search" in the replace panel.

MojaveWastelander · 2016-10-03T18:54:42Z

Hello, what do you mean by "bookmarks are always affected"? I used a test file and set some bookmarks, then I made a few searches and closed the window, all bookmarks remained unchanged and marks were removed. Regarding replace panel is need to remove the check in code. There is also a bug when a search is done in one document and then switching to another one does not clear marks in previous document.

cmeriaux · 2016-10-04T09:05:41Z

Hello,
I did more tests to confirm the problem :
If "Mark/Bookmark line" is enable in the Mark panel, the Quick find function in "Find" panel always affect the existing bookmark.
If "Mark/Bookmark line" is disable in the Mark panel, bookmark are not affected however, bookmarked words always loose their mark color. For me It's a problem. I think that "quick find" should use another color than bookmark.
As a good example, "Incremental Search" (available in "search" menu) do something similar than "quick find" but use a different Scintilla Color. So it doesn't perturbate "Mark" and "bookmark" function

Scintilla allows you to define multiple style
Here is style used by Npp:

#define SCE_UNIVERSAL_FOUND_STYLE 31
#define SCE_UNIVERSAL_FOUND_STYLE_SMART 29
#define SCE_UNIVERSAL_FOUND_STYLE_INC 28
#define SCE_UNIVERSAL_TAGMATCH 27
#define SCE_UNIVERSAL_TAGATTR 26
#define SCE_UNIVERSAL_FOUND_STYLE_EXT1 25
#define SCE_UNIVERSAL_FOUND_STYLE_EXT2 24
#define SCE_UNIVERSAL_FOUND_STYLE_EXT3 23
#define SCE_UNIVERSAL_FOUND_STYLE_EXT4 22
#define SCE_UNIVERSAL_FOUND_STYLE_EXT5 21

You may create a new one, or use the icnremental style (SCE_UNIVERSAL_FOUND_STYLE_INC)

http://www.scintilla.org/ScintillaDoc.html#SCI_INDICSETSTYLE

Another problem, "Quick find" follows the direction configured. I think it should process the complete document.

Added member function that clears marks by style. Clear marks when switching between search tabs.

MojaveWastelander · 2016-10-04T10:59:59Z

The problem was with the ProcessOperation I was using, ProcessMarkAll was using _doMarkLine setting, I switched to ProcessMarkAll_IncSearch which just marks specific ranges and uses SCE_UNIVERSAL_FOUND_STYLE_INC. Regarding direction it actually is searching whole document by setting SCI_SETCURRENTPOS to 0.

MAPJe71 · 2016-10-04T11:11:57Z

PowerEditor/src/ScitillaComponent/FindReplaceDlg.cpp

@@ -2278,6 +2278,7 @@ void FindReplaceDlg::enableReplaceFunc(bool isEnable)
 	::ShowWindow(::GetDlgItem(_hSelf, IDC_FINDALL_OPENEDFILES), !hideOrShow);
 	::ShowWindow(::GetDlgItem(_hSelf, IDCCOUNTALL),!hideOrShow);
 	::ShowWindow(::GetDlgItem(_hSelf, IDC_FINDALL_CURRENTFILE),!hideOrShow);
+	::ShowWindow(::GetDlgItem(_hSelf, ID_QUICK_FIND), SW_SHOW);


Is the SW_SHOW deliberate or should it be !hideOrShow as is in the three lines above it?
When deliberate add a explanatory comment to prevent anyone to interpret as a copy/paste error.

Yes, it should not depend on isEnable argument as it should be visible on search and replace tabs, I'll add a comment.

cmeriaux · 2016-10-05T05:48:39Z

@MojaveWastelander What you've done is very nice. Thanks a lot.
What about adding in the mark panel the similar function "quick mark" ? Is it possible ?
Once again, thanks.

cmeriaux · 2016-10-05T17:21:27Z

@MojaveWastelander here is another problem.
When "quick find" is enable, the auto-fill of search field with the selected word is broken. Do you confirm ?

cmeriaux · 2016-10-05T18:02:04Z

@MojaveWastelander here is another problem concerning Smart Highlighting.
Start from a fresh Notepad++
Select a word.
Check that SmartHighlighting works : it highlights all similar words
Open find panel
Do a quick find
close find panel
Try again the Smart Highlighting. It should'nt works anymore until Npp restart.

Do you confirm ?

MojaveWastelander · 2016-10-05T18:30:50Z

Yes and yes, I'll look into it. Thanks for feedback.

Fix: words under caret not taken as search values when search window is opened.

MojaveWastelander · 2016-10-06T17:15:24Z

Seems to be fixed now, took longer to find what was causing the second issue than to fix it. The question now is when to save or to save in general quick search queries? Right now when quick search is enabled nothing that is written in the search box is saved.

dail8859 · 2016-10-06T18:51:34Z

Still has a problem with regular expressions locking it up.

Also using ~~escaped~~ newline characters with regular expressions is broken, even with "Quick find" turned off:

Open new file
Press enter 3 times
Open find dialog
Set mode to Regular expression
"Quick find" doesn't matter if it is checked or not
Search for \r\n (assuming windows line endings)
No matches

Doing the above steps with the v7 release counts 3 matches.

Also, even on what I would consider "small" files (~500kB) having lots of matches can cause N++ to have noticeable lag. If possible I'd suggest once the first match is found don't search any further than you have to (e.g. only the text visible on the screen). However, this would probably also mean getting the Scintilla notifications if the view is scrolled to research the text on the screen.

Enabled by default, not saved in settings.

Forcing someone to use this every time they open N++ is not a good idea. Personally I open large files quite often and search through them. I wouldn't want to to have to uncheck this every time.

MojaveWastelander · 2016-10-07T06:58:03Z

Regarding regex search I'm using search methods provided by n++, so "quick find" search is the same as default search. On version that I develop on there doesn't seem to be issues with regex search, I guess it was some issue in previous version.
From what I seen marking only matches on the current view is possible.
"enabled by default" is more of a testing state, when feature will be more polished it will be disabled by default.

…ines) Fix: When switching documents marks set by quick find in current document are removed Update: quick find check box disabled by default

…l try to find a match in whole document (only if search is requested from the dialog)

cmeriaux · 2016-10-07T17:20:34Z

hello @MojaveWastelander
Another issue with the last version

When quick search is selected but panel is closed, the function Find volatile next is broken. "Find volatile next" finds the first occurence of the selected word.
Same issue with find volatile previous, find next and find previous

Do you confirm the issue ?

Thanks

…search doesn't work

MojaveWastelander · 2016-10-07T18:31:04Z

Hello, I disabled the option when search dialog is "closed", so all external search methods should not be affected by it.

cmeriaux · 2016-10-07T19:23:22Z

It's validated here. Thanks a lot
I wish you a good week-end

cmeriaux · 2016-11-03T06:11:31Z

Hello,
what is your last commit (merge branch ....)
You should remove it with 'git rebase -i' command

cmeriaux · 2016-11-03T06:16:45Z

PowerEditor/src/ScitillaComponent/FindReplaceDlg.rc

@@ -37,6 +37,7 @@ EXSTYLE WS_EX_TOOLWINDOW
 CAPTION "Replace"
 FONT 8, "MS Shell Dlg", 0, 0, 0x0
 BEGIN
+    AUTOCHECKBOX    "&Quick find", ID_QUICK_FIND, 129, 115, 125, 8, 0, WS_EX_LEFT


elsewhere they used other syntax

CONTROL "&Quick find",ID_QUICK_FIND,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,

What about using it ?

This line was generated by ResEdit and I didn't looked what is the difference between using syntax with CONTROL, I guess I should use it as well for consistency.

MojaveWastelander · 2016-11-03T07:15:48Z

Hello, I made those fixes at work computer, but I when I tried to commit them there was one commit on github that I didn't pulled before making those fixes, so I merged those commits.

…rent view. Fix: Quick find does not wrap search when no matches found.

Variable name update.

donho · 2016-11-13T16:06:49Z

There's already a feature named incremental search which does the same thing (CTRL+ALT+I).
I prefer to not mix the both so user can choose the different GUI, and of course, no regression.

cmeriaux · 2016-11-14T17:52:15Z

@donho the feature incremental search that already exist is useless. It's far beyond the classical search search due the missing options (search mode option, whole word only option ...)
It should me decommissioned and replaced by the one developped by @MojaveWastelander or something available in the find and replace GUI.

Moreover, an incremental mode is very useful in Regular Expression mode. It allows us to validate the regular expression interactively before doing a replace.

MojaveWastelander · 2016-11-23T10:13:15Z

Initially the idea was to add this functionality to incremental search (it makes more sense for it to be there), but I left it on find for testing purposes (as it had all checkboxes and features available and easily accessible). One of main differences from incremental search is that search is done in current view, thus typing search query is fast no matter how big file is (it was one of issues mentioned before). Main idea is that incremental search is incomplete feature-wise and it could use some ideas that I implemented.

MojaveWastelander added 8 commits October 2, 2016 22:32

Added quick find functionality.

c2ef8a6

Clear all marked text without affecting bookmarks.

966ef61

Do not flash dialog when match not found in quick find mode.

1553095

Update search when search selection combobox changes and unmark all m…

9994ae2

…atches when search dialog us hidden.

Process search box selection change.

078e87f

Search box caret stay on same position after refocus.

988ab42

Marks are cleared always before trying to find a match.

Update search when changing "Search mode" controls.

5b1635b

Appveyor msvc issue fix.

47d7f89

Quick find is available in replace tab as well.

88be074

Extracted quick find function as a member function.

4a8766f

Added member function that clears marks by style. Clear marks when switching between search tabs.

MAPJe71 reviewed Oct 4, 2016

View reviewed changes

Quick find checkbox should be visible in both find and replace tabs.

d95aeff

Fix: smart highlighter not working after using quick find.

48d2122

Fix: words under caret not taken as search values when search window is opened.

MojaveWastelander added 3 commits October 7, 2016 13:34

Update: quick find marks only matches in current view (only visible l…

39e2589

…ines) Fix: When switching documents marks set by quick find in current document are removed Update: quick find check box disabled by default

Fix: in case 'quick find' doesn't find a match in current view it wil…

f80082c

…l try to find a match in whole document (only if search is requested from the dialog)

Missing header.

9e987a7

Fix: when search window is closed and quick find is enabled volatile …

a4c4cbe

…search doesn't work

cmeriaux reviewed Nov 3, 2016

View reviewed changes

MojaveWastelander added 2 commits November 3, 2016 09:38

Fix: Find next does not mark matches when finding a match outside cur…

fbd5205

…rent view. Fix: Quick find does not wrap search when no matches found.

Use same syntax style for checkboxs in resource file.

2d1389d

Variable name update.

MojaveWastelander force-pushed the quick_find_functionality branch from 6af19b6 to 2d1389d Compare November 3, 2016 07:41

donho closed this Nov 13, 2016

cmeriaux mentioned this pull request May 12, 2020

incremental find dialog: add support of regexp and extended search mode #8247

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quick find functionality #2383

Quick find functionality #2383

MojaveWastelander commented Oct 3, 2016 •

edited

cmeriaux commented Oct 3, 2016

MojaveWastelander commented Oct 3, 2016 •

edited

cmeriaux commented Oct 4, 2016

MojaveWastelander commented Oct 4, 2016 •

edited

MAPJe71 Oct 4, 2016

MojaveWastelander Oct 4, 2016 •

edited

cmeriaux commented Oct 5, 2016

cmeriaux commented Oct 5, 2016

cmeriaux commented Oct 5, 2016

MojaveWastelander commented Oct 5, 2016

MojaveWastelander commented Oct 6, 2016

dail8859 commented Oct 6, 2016 •

edited

MojaveWastelander commented Oct 7, 2016

cmeriaux commented Oct 7, 2016

MojaveWastelander commented Oct 7, 2016

cmeriaux commented Oct 7, 2016

cmeriaux commented Nov 3, 2016

cmeriaux Nov 3, 2016

MojaveWastelander Nov 3, 2016

MojaveWastelander commented Nov 3, 2016 •

edited

donho commented Nov 13, 2016

cmeriaux commented Nov 14, 2016

MojaveWastelander commented Nov 23, 2016 •

edited

Quick find functionality #2383

Quick find functionality #2383

Conversation

MojaveWastelander commented Oct 3, 2016 • edited

cmeriaux commented Oct 3, 2016

MojaveWastelander commented Oct 3, 2016 • edited

cmeriaux commented Oct 4, 2016

MojaveWastelander commented Oct 4, 2016 • edited

MAPJe71 Oct 4, 2016

Choose a reason for hiding this comment

MojaveWastelander Oct 4, 2016 • edited

Choose a reason for hiding this comment

cmeriaux commented Oct 5, 2016

cmeriaux commented Oct 5, 2016

cmeriaux commented Oct 5, 2016

MojaveWastelander commented Oct 5, 2016

MojaveWastelander commented Oct 6, 2016

dail8859 commented Oct 6, 2016 • edited

MojaveWastelander commented Oct 7, 2016

cmeriaux commented Oct 7, 2016

MojaveWastelander commented Oct 7, 2016

cmeriaux commented Oct 7, 2016

cmeriaux commented Nov 3, 2016

cmeriaux Nov 3, 2016

Choose a reason for hiding this comment

MojaveWastelander Nov 3, 2016

Choose a reason for hiding this comment

MojaveWastelander commented Nov 3, 2016 • edited

donho commented Nov 13, 2016

cmeriaux commented Nov 14, 2016

MojaveWastelander commented Nov 23, 2016 • edited

MojaveWastelander commented Oct 3, 2016 •

edited

MojaveWastelander commented Oct 3, 2016 •

edited

MojaveWastelander commented Oct 4, 2016 •

edited

MojaveWastelander Oct 4, 2016 •

edited

dail8859 commented Oct 6, 2016 •

edited

MojaveWastelander commented Nov 3, 2016 •

edited

MojaveWastelander commented Nov 23, 2016 •

edited