Shortcut improvements #3584
Shortcut improvements #3584
Conversation
Shorcut mapper - main panel : new colums that show the category of the shortcut Shorcut mapper - plugin panel : new colums that show the plugin name that the shortcut belongs to Shorcut mapper - scintilla panel : it shows every shortcuts configured for one command
| @@ -193,12 +194,42 @@ protected : | |||
|
|
|||
| class CommandShortcut : public Shortcut { | |||
| public: | |||
| CommandShortcut(Shortcut sc, long id) : Shortcut(sc), _id(id) {}; | |||
| CommandShortcut(Shortcut sc, long id) : Shortcut(sc), _id(id) { | |||
| long category_id = _id - _id % 500; | |||
There was a problem hiding this comment.
why 500? Magic number should be avoided.
| default : | ||
| _category = TEXT(""); break; | ||
| } | ||
| }; | ||
| unsigned long getID() const {return _id;}; |
There was a problem hiding this comment.
Function long definition should be in cpp file.
|
@cmeriaux Nice PR. |
move long constructor from .hpp to .cpp remove magic number
|
@donho I've done your change request. I noticed that some constants are not declared as expected. Wrong code: #define IDM_EDIT_AUTOCOMPLETE (50000 + 0)
#define IDM_EDIT_AUTOCOMPLETE_CURRENTFILE (50000 + 1)
#define IDM_EDIT_FUNCCALLTIP (50000 + 2)
#define IDM_EDIT_AUTOCOMPLETE_PATH (50000 + 6)
#define IDM_VIEW_GOTO_ANOTHER_VIEW 10001
#define IDM_VIEW_CLONE_TO_ANOTHER_VIEW 10002
#define IDM_VIEW_GOTO_NEW_INSTANCE 10003
#define IDM_VIEW_LOAD_IN_NEW_INSTANCE 10004expected code: #define IDM_EDIT_AUTOCOMPLETE (IDM_EDIT + 100)
#define IDM_EDIT_AUTOCOMPLETE_CURRENTFILE (IDM_EDIT + 101)
#define IDM_EDIT_FUNCCALLTIP (IDM_EDIT + 102)
#define IDM_EDIT_AUTOCOMPLETE_PATH (IDM_EDIT + 103)
#define IDM_VIEW_GOTO_ANOTHER_VIEW (IDM_VIEW + 200)
#define IDM_VIEW_CLONE_TO_ANOTHER_VIEW (IDM_VIEW + 201)
#define IDM_VIEW_GOTO_NEW_INSTANCE (IDM_VIEW + 202)
#define IDM_VIEW_LOAD_IN_NEW_INSTANCE (IDM_VIEW + 203)I didn't change anything to avoid regression. Do I fix it ? |
| _category = TEXT("Setting"); | ||
| else if ( _id < IDM_EXECUTE) | ||
| _category = TEXT("Tool"); | ||
| else if ( _id < IDM_EXECUTE) |
There was a problem hiding this comment.
Checking for IDM_EXECUTE twice?
No, please leave it as it is. They are being used for the translation. |
|
@cmeriaux please remove duplicated code. |
|
@cmeriaux It seems you add your new commits on the old branch which has been merged since long time. It's bad because there'll be the merge problem on my side. |
Fixes #3583
Shorcut mapper - main panel : new colums that show the category of the shortcut
Shorcut mapper - plugin panel : new colums that show the plugin name that the shortcut belongs to
Shorcut mapper - scintilla panel : it shows every shortcuts configured for one command