Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update russian.xml to v7.5 #3644

Closed
wants to merge 2 commits into from
Closed

Update russian.xml to v7.5 #3644

wants to merge 2 commits into from

Conversation

dragomano
Copy link

Fix "CamelCase" translation to correct "russian style".
Translation of new/missing strings (7.5).

@donho donho added the reject label Aug 24, 2017
<Item id="10003" name="Переместить в Новый Экземпляр"/>
<Item id="10004" name="Открыть в Новом Экземпляре"/>
</Commands>
<Native-Langue name="Русский" filename="russian.xml" version="7.5">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come all the remove & added lines for the same content?

@donho
Copy link
Member

donho commented Aug 24, 2017

Here are my suggestions:

  1. Do without changing the tab/space. Your modification should be minimum and pertinent to make review easier.
  2. your commit should be clean: the 2nd commit (Merge branch 'master' into patch-1) shouldn't be here.

@donho donho closed this Aug 24, 2017
@dragomano dragomano deleted the patch-1 branch August 24, 2017 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants