Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check sign in Encoding menu not always shown #3738

Closed
wants to merge 1 commit into from
Closed

Fix check sign in Encoding menu not always shown #3738

wants to merge 1 commit into from

Conversation

Cyrillev91
Copy link
Contributor

Fix #3737

@Cyrillev91
Copy link
Contributor Author

example:
after select ISO 8859-5 :
Encoding >> Character sets >> Cyrillic >> ISO 8859-5

Without this PR : ISO 8859-5 is not checked
fixchecksigninencodingmenu_before

With this PR : ISO 8859-5 is checked
fixchecksigninencodingmenu_after

@donho
Copy link
Member

donho commented Aug 4, 2019

Can you explain why only Character sets >> Central European >> OEM 852 and Character sets >> Central European >> Windows-1250 work ?

@donho donho self-assigned this Aug 4, 2019
@donho donho added this to the 7.x (master) milestone Aug 4, 2019
@donho donho closed this in 053823e Aug 4, 2019
kspalaiologos pushed a commit to kspalaiologos/notepad-plus-plus that referenced this pull request Jan 17, 2021
@Cyrillev91 @donho
Fix check sign in Encoding menu not shown issue
3474062 
Fix notepad-plus-plus#3737, close notepad-plus-plus#3738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@donho donho

Labels
accepted bug
Projects
None yet
Milestone
7.x (master)
Development

Successfully merging this pull request may close these issues.

The selected encoding used for the file opened in Notepad ++ is not always displayed in the Encoding menu
2 participants
@Cyrillev91 @donho