New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update makefile for mingw gcc builds #4145
Conversation
@chcg Can you please (maybe with an additional PR) adjust https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/appveyor.yml to include a MinGW GCC build? |
@GitMensch See #2478 with just this changes the build still fails, due to ATL, which is not available for mingw. So adding an additional build for it just makes sense, if it is planned to get this build running, either by disabling the problematic code via #ifdef or by some stub similar to #1663. Maybe in the meantime also some new issues were introduced. Therefore some agreement from donho is needed what will be accepted. |
@GitMensch See also #4776 for a probably functional version. |
@chcg Does this PR still be updated (compiled by MinGW) ? |
As this is 2 years old a rebase and adaption to current changes is necessary, reflecting:
as far as I see. Some commits in the meantime are already helping to get closer to goal to have a mingw build like removal of the ATL by usage of C++11 mutex and Force cpp standard const char pointer on string literals I could do a rebase and adapt. |
ab5b530
to
665a72a
Compare
So this is WIP, appveyor will be incompatible modified until the makefile is updated. |
cdd8d1a
to
6a8dc12
Compare
0933cc0
to
09b2555
Compare
@donho See https://ci.appveyor.com/project/chcg/notepad-plus-plus/builds/28608301/job/85t95ficdgio8i5h/artifacts, seems to be a first working version, if combined with a signed SciLexer.dll. Quite huge as it is a debug build with all dependency libs apart from SciLexer.dll linked in. |
This is very good news. Can you target for a non-static non-debug build [a different make target] next? |
09b2555
to
82cb8a6
Compare
82cb8a6
to
69da599
Compare
@chcg |
@donho
I will work on that for an updated PR and maybe also add a linux build. |
, see also #3918
Last update was #2478.