Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update makefile for mingw gcc builds #4145

Closed
wants to merge 1 commit into from

Conversation

chcg
Copy link
Contributor

@chcg chcg commented Feb 4, 2018

, see also #3918

Last update was #2478.

@GitMensch
Copy link
Contributor

GitMensch commented Mar 6, 2018

@chcg Can you please (maybe with an additional PR) adjust https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/appveyor.yml to include a MinGW GCC build?
If it is integrated there wouldn't be another incompatible change in the future...

@chcg
Copy link
Contributor Author

chcg commented Mar 6, 2018

@GitMensch See #2478 with just this changes the build still fails, due to ATL, which is not available for mingw. So adding an additional build for it just makes sense, if it is planned to get this build running, either by disabling the problematic code via #ifdef or by some stub similar to #1663. Maybe in the meantime also some new issues were introduced.

Therefore some agreement from donho is needed what will be accepted.

@chcg chcg mentioned this pull request Mar 29, 2018
@chcg
Copy link
Contributor Author

chcg commented Aug 28, 2018

@GitMensch See also #4776 for a probably functional version.

@donho
Copy link
Member

donho commented Oct 29, 2019

@chcg Does this PR still be updated (compiled by MinGW) ?

@donho donho self-assigned this Oct 29, 2019
@chcg
Copy link
Contributor Author

chcg commented Nov 1, 2019

As this is 2 years old a rebase and adaption to current changes is necessary, reflecting:

as far as I see. Some commits in the meantime are already helping to get closer to goal to have a mingw build like removal of the ATL by usage of C++11 mutex and Force cpp standard const char pointer on string literals

I could do a rebase and adapt.

@chcg chcg force-pushed the mingw_gcc_update branch 2 times, most recently from ab5b530 to 665a72a Compare November 1, 2019 09:56
@chcg
Copy link
Contributor Author

chcg commented Nov 1, 2019

So this is WIP, appveyor will be incompatible modified until the makefile is updated.

@chcg chcg force-pushed the mingw_gcc_update branch 18 times, most recently from cdd8d1a to 6a8dc12 Compare November 2, 2019 08:07
@chcg chcg force-pushed the mingw_gcc_update branch 18 times, most recently from 0933cc0 to 09b2555 Compare November 4, 2019 20:21
@chcg
Copy link
Contributor Author

chcg commented Nov 4, 2019

@donho See https://ci.appveyor.com/project/chcg/notepad-plus-plus/builds/28608301/job/85t95ficdgio8i5h/artifacts, seems to be a first working version, if combined with a signed SciLexer.dll. Quite huge as it is a debug build with all dependency libs apart from SciLexer.dll linked in.

@GitMensch
Copy link
Contributor

This is very good news. Can you target for a non-static non-debug build [a different make target] next?

@donho
Copy link
Member

donho commented Nov 7, 2019

@chcg
Looks good to me.
Sorry for the wait.

@donho donho added the accepted label Nov 7, 2019
@donho donho closed this in c741f83 Nov 7, 2019
@chcg
Copy link
Contributor Author

chcg commented Nov 8, 2019

@donho
Some points remain I think:

  • UserDefineDialog.cpp
    I think it should be possible to do the std::find() also for mingw
  • functionListPanel.cpp
    check ofstream usage, maybe via basic_ofstream<TCHAR>
  • appveyor.yml mingw config
    scintilla is build just as release version
    notepad++ seems to be just debug

I will work on that for an updated PR and maybe also add a linux build.

@chcg chcg deleted the mingw_gcc_update branch January 2, 2021 09:27
kspalaiologos pushed a commit to kspalaiologos/notepad-plus-plus that referenced this pull request Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants