Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulu and kurdish translation fix #5397

Closed
wants to merge 1 commit into from
Closed

zulu and kurdish translation fix #5397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions PowerEditor/Test/FunctionList/cpp/unitTest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3773,6 +3773,8 @@ generic_string NppParameters::getLocPathFromStr(const generic_string & localizat
return TEXT("vietnamese.xml");
if (localizationCode == TEXT("cy-gb"))
return TEXT("welsh.xml");
if (localizationCode == TEXT("zu") || localizationCode == TEXT("zu-za"))
return TEXT("zulu.xml");

return generic_string();
}
Expand Down
2 changes: 1 addition & 1 deletion PowerEditor/installer/nativeLang/kurdish.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8" ?>
<?xml version="1.0" encoding="utf-8" ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the change of this line?

Copy link
Contributor Author

@chcg chcg Mar 13, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed from UTF8 with BOM -> plain UTF8 otherwise the switch to this language is not working.
Tested with 7.6.4 from the portable version. It is already visible in the preference dialogue that the switch is not working and the fallback to english happens.

<NotepadPlus>
<Native-Langue name="كوردی" RTL="yes" filename="kurdish.xml" version="7.5">
<Menu>
Expand Down
2 changes: 1 addition & 1 deletion PowerEditor/installer/nativeLang/zulu.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8" ?>
<?xml version="1.0" encoding="utf-8" ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed from UTF8 with BOM -> plain UTF8 otherwise the switch to this language is not working.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chcg could you merge a commit properly?
I can always do it, but if you can, it'll be better.

<!--
***********************************************************************************
zulu language binary translations file for Notepad++ ::
Expand Down
2 changes: 2 additions & 0 deletions PowerEditor/src/Parameters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3926,6 +3926,8 @@ generic_string NppParameters::getLocPathFromStr(const generic_string & localizat
return TEXT("vietnamese.xml");
if (localizationCode == TEXT("cy-gb"))
return TEXT("welsh.xml");
if (localizationCode == TEXT("zu") || localizationCode == TEXT("zu-za"))
return TEXT("zulu.xml");

return generic_string();
}
Expand Down
2 changes: 1 addition & 1 deletion PowerEditor/src/localizationString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,5 @@ LocalizationSwitcher::LocalizationDefinition localizationDefs[] =
{TEXT("Brezhoneg"), TEXT("breton.xml")},
{TEXT("کوردی‬"), TEXT("kurdish.xml")},
{TEXT("Pig latin"), TEXT("piglatin.xml")},
{TEXT("Zulu"), TEXT("zulu.xml")}
{TEXT("Zulu"), TEXT("zulu.xml")}
};