Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DansLeRuSH dark theme (20200511) #8252

Conversation

DansLeRuSH
Copy link
Contributor

Hi team,

I resubmit my dark theme after a correction on too much "-" in comments and with a better name for the branch as seen with Don.

Best regards,
Franck

Fixed special characters in comments that invalidated XML
@dail8859
Copy link
Contributor

If your expectation is to have this theme available via the installer, just dropping the xml file in that directory is not enough.

https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/installer/nsisInclude/themes.nsh Needs updated as well.

@donho donho self-assigned this May 12, 2020
@donho
Copy link
Member

donho commented May 12, 2020

@dail8859 Nice catch. I'll update it if this PR is accepted.

@DansLeRuSH
Copy link
Contributor Author

If your expectation is to have this theme available via the installer, just dropping the xml file in that directory is not enough.

https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/installer/nsisInclude/themes.nsh Needs updated as well.

OK so sorry to missed this (not yet very familiar with all the process) ...

@dail8859 Nice catch. I'll update it if this PR is accepted.

... and thank you for that ! 🖖😃

@donho donho added the accepted label May 13, 2020
@donho donho closed this in bdb9b28 May 13, 2020
alef162 pushed a commit to alef162/notepad-plus-plus that referenced this pull request Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants