Make CURRENT_LINE and CURRENT_COLUMN expansions one-based

[sasumner]

Fixes #8679

[dail8859]

Couldn't this potentially break plugins that are expecting it to be zero based? Not saying it is correct, just that the behavior will change.

[sasumner]

Couldn't this potentially break plugins that are expecting it to be zero based?

It could. Perhaps plugins was its primary use?
I can't see this at a user-level at all, as all other tools I've seen that deal with line and column numbers deal with "user" concepts of one-based numbers.

Should I back off and create $(CURRENT_LINE1) and $(CURRENT_COLUMN1) ?

[dail8859]

I guess that would be Don's call. That suggestion would ensure compatibility and would be my preference.

[sasumner]

I guess that would be Don's call. That suggestion would ensure compatibility and would be my preference.

Let's just go with that, then.
No need to wait for Don on it.
I'll rework it...
Closing until rework is done.

[Yaron10]

Do plugin use $(CURRENT_LINE) or NPPM_GETCURRENTLINE?

If the latter is correct, how about changing wsprintf(expandedStr, TEXT("%d"), lineNumber); to wsprintf(expandedStr, TEXT("%d"), lineNumber + 1); instead of the current change?

(In RunDlg/RunDlg.cpp).