Add GUI in preferences dialog for adding URI customized schemes #9195
Conversation
and make naming conventional.
donho
changed the title
| @@ -849,7 +849,7 @@ struct NppGUI final | |||
| bool _isWordCharDefault = true; | |||
| std::string _customWordChars; | |||
| urlMode _styleURL = urlUnderLineFg; | |||
| generic_string _customizedShemes = TEXT("svn:// cvs:// git:// imap:// irc:// irc6:// ircs:// ldap:// ldaps:// news: telnet:// gopher:// ssh:// sftp:// smb:// skype: snmp:// spotify: steam:// sms: slack:// chrome:// bitcoin:"); | |||
| generic_string _uriShemes = TEXT("svn:// cvs:// git:// imap:// irc:// irc6:// ircs:// ldap:// ldaps:// news: telnet:// gopher:// ssh:// sftp:// smb:// skype: snmp:// spotify: steam:// sms: slack:// chrome:// bitcoin:"); | |||
There was a problem hiding this comment.
@donho Spelling _uriShemes -> _uriSchemes :-)
There was a problem hiding this comment.
But you didn't change the spelling problem? :-)
|
Okay, so I didn't actually review the code so much as try out the feature. Taking a cue from HERE (a user complaint about his custom linking behavior that used to work but is broken in 7.9.1), I recreated this user's setup on my system and tried to get it to work in the current (as of this writing) codebase. I will report that I had success. Summary: I added this: And after that I was able to achieve links in text such as these: I did notice that the links with pathnames must all contain forward slashes in order to be recognized as links, for example, this is NOT recognized as a link: This is in contrast to earlier versions of N++ (I used 7.8.6) where backslashes WERE recognized, and mixed slashes as well, examples: I suppose that I should add that, like the user with the complaint, I had the registry entries for "np" call a batch file (that handles stripping the |
I agree also. |
Related: 5168bdb and #9155