Add "Assign file type" checkbox to Save As dialog #9732

mere-human · 2021-04-06T09:33:47Z

mere-human · 2021-04-06T09:35:04Z

How it works:
Save As dialog now has Append extension checkbox (default is ON).
If it's ON, the file type (in dialog drop-down) as well as file extension is set based on document language.
If checkbox is OFF, then the file type is set to *.* and the file extension isn't added.
The checkbox value is remembered between runs.
The option Set Save dialog file extension filter to *.* is removed from the Preferences.

Demo:

save-dlg-assign-type.mp4

Append file extension if checkbox is ON.

donho · 2021-04-06T23:47:32Z

Just a suggestion:
Using "Apply current doc. language filter" (instead of "Assign file type") may be more relevant for users.

mere-human · 2021-04-07T08:49:12Z

@donho

Using "Apply current doc. language filter" (instead of "Assign file type") may be more relevant for users.

This seems too long as for me. At least, it could be "Apply file language filter" or something like this.

But there are more ideas. I'm not sure what is the best option yet.
Please, see the latest comment here #9515 (comment) and links to community forum.

mere-human · 2021-04-13T07:59:24Z

I should probably remove the checkbox from the preferences.

The same preference still can be set from the save dialog. The value is saved to XML as before.

donho

Remove getNppGUIMutable(). Use getNppGUI instead.
Change IDC_CHECK_AUTOUPDATE control's Y position.

PowerEditor/src/Parameters.h

PowerEditor/src/WinControls/Preference/preference.rc

donho

Remove getNppGUIMutable(). Use getNppGUI instead.
Change IDC_CHECK_AUTOUPDATE control's Y position.

mere-human · 2021-04-15T19:07:38Z

PowerEditor/src/WinControls/Preference/preference.rc

-    CONTROL         "Mute all sounds", IDC_CHECK_MUTE_SOUNDS, "Button", BS_AUTOCHECKBOX | BS_MULTILINE | WS_TABSTOP, 37, 94, 217, 10
-    CONTROL         "Enable Notepad++ auto-updater",IDC_CHECK_AUTOUPDATE,"Button",BS_AUTOCHECKBOX | BS_MULTILINE | WS_TABSTOP, 37, 78, 210, 10
-    CONTROL         "Set Save dialog file extension filter to *.*",IDC_CHECK_SAVEDLGEXTFILTALLTYPES,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,37,109,267,10
+    CONTROL         "Enable Notepad++ auto-updater",IDC_CHECK_AUTOUPDATE,"Button",BS_AUTOCHECKBOX | BS_MULTILINE | WS_TABSTOP, 37, 94, 210, 10


I moved it upper in the code so it corresponds to the comment that says "Enable Notepad++ auto-updater" should be always the 1st item".
It was me who added "Mute all sounds" in the wrong place 😬

sasumner · 2021-04-16T11:57:38Z

@mere-human Hooray! I like it.
I should cautiously add: "We'll see how it goes with users".

mere-human · 2021-04-16T11:59:34Z

I should cautiously add: "We'll see how it goes with users".

Users don't stop to surprise me with what they request and how they're able break our features 😄

sasumner · 2021-04-16T12:06:09Z

Users don't stop to surprise me with what they request and how they're able break our features

Yes, but this one is a very special case. It seems to be one where we can't predict what will arise.
Hopefully we (you!) are "honing in" on the final solution (the one that generates no more complaints).
It has been a long saga (6+ years) starting with old/new style user questions/problems...and probably hundreds of related Community postings...sigh...

sasumner · 2021-04-17T10:56:58Z

@mere-human

Can you update the user manual for this feature?
Having said that, I'm not sure the best area it belongs in.
On the upside, I think I was remiss and never added the setting you just removed from the Preferences, so nothing will need to be removed there.

mere-human · 2021-04-17T11:00:05Z

@mere-human

Can you update the user manual for this feature?

Sure, I will check it. Should I write something like in my 2nd comment in this PR?

sasumner · 2021-04-17T11:04:43Z

like in my 2nd comment in this PR?

Very reasonable.
I'll let you create your own issue in the user manual issue tracker.
Thanks!

mere-human · 2021-04-17T13:36:26Z

@pryrt Do you have an idea whether this should be documented and what section it belongs to?

sasumner · 2021-04-18T11:05:47Z

whether this should be documented

I thought we established this.
A strong YES. :-)

what section it belongs to?

It may need a new section.
And yes @pryrt 's thoughts on that would be super to have.
Normally there is no need to discuss open/save dialogs as everyone that uses Windows knows how they work. !!

pryrt · 2021-06-01T13:28:03Z

@mere-human / @sasumner ,

Have Alan Kilborn and I misunderstood the intention of the "Append extension" checkbox, as Alan describes in the Forum here? Because as I understood its intention, if you type a filename with no extension when the "Append extension" is checked, Alan and I expect it to automatically add the first extension from the current Save As type. But in Alan's experiment on 8.0-RC2, it does not append the extension if there is no extension in the file-name box.

And that's how I described it in the v8 usermanual:

... So if my understanding was wrong, I'm going to need to fix that, too.

mere-human · 2021-06-01T20:51:25Z

But in Alan's experiment on 8.0-RC2, it does not append the extension if there is no extension in the file-name box.

Indeed, it should work as described. But it shouldn't because there is a bug.
I'm going to fix that.

mere-human · 2021-06-01T20:58:20Z

@pryrt Does it work if you press Enter key or Alt+S?

sasumner · 2021-06-01T21:01:41Z

@mere-human

I tried it:

Enter key: works! (.txt extension added automagically)
Alt+s: doesn't work (no extension added)

donho · 2021-06-03T01:17:57Z

@mere-human So is it a regression due to this PR?
Any opened issue about it?

mere-human · 2021-06-03T08:26:22Z

@mere-human So is it a regression due to this PR?
Any opened issue about it?

Yes, it is a regression.
I haven't seen any issue about it. I'll create one to document everything related.

sasumner · 2021-06-03T11:06:07Z

regression

Nitpick: I would call it a bug because this checkbox is new functionality -- nothing to "regress".

mere-human added 2 commits April 6, 2021 21:36

Add "Assign file type" checkbox to Save As dialog

5095768

Append file extension if checkbox is ON.

Fix x86 build by using size_t instead of int

4304477

mere-human force-pushed the issue-9515-save-type branch from 4a882d4 to 4304477 Compare April 6, 2021 18:38

mere-human mentioned this pull request Apr 6, 2021

Move "Set Save dialog file extension filter to *.*" pref. setting to the SaveAs dialog #9515

Closed

Fix MinGW build by changing function overload

141a5ab

chcg added the enhancement Proposed enhancements of existing features label Apr 7, 2021

Change checkbox label text

f7e959d

mere-human marked this pull request as ready for review April 12, 2021 18:35

Remove "Set Save dialog file extension filter to *.*" preference

dd1022b

The same preference still can be set from the save dialog. The value is saved to XML as before.

donho self-assigned this Apr 14, 2021

donho reviewed Apr 14, 2021

View reviewed changes

PowerEditor/src/Parameters.h Outdated Show resolved Hide resolved

PowerEditor/src/WinControls/Preference/preference.rc Outdated Show resolved Hide resolved

donho requested changes Apr 15, 2021

View reviewed changes

Move auto-updater preference upper and remove NppGUI getter

e98b143

mere-human requested a review from donho April 15, 2021 19:04

mere-human commented Apr 15, 2021

View reviewed changes

mere-human mentioned this pull request Apr 15, 2021

"Default Directory" preference no longer works since the 7.95 release #9767

Closed

donho approved these changes Apr 15, 2021

View reviewed changes

donho added the accepted label Apr 15, 2021

donho closed this in e3dbeda Apr 15, 2021

mere-human deleted the issue-9515-save-type branch April 16, 2021 08:35

pryrt mentioned this pull request Apr 18, 2021

Add "Other Toggles and Settings" notepad-plus-plus/npp-usermanual#200

Closed

pryrt mentioned this pull request Jun 1, 2021

clarifying historical and new save-as extensions prefs notepad-plus-plus/npp-usermanual#236

Closed

mere-human mentioned this pull request Jun 3, 2021

Append extension doesn't work in Save As dialog #9939

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "Assign file type" checkbox to Save As dialog #9732

Add "Assign file type" checkbox to Save As dialog #9732

mere-human commented Apr 6, 2021

mere-human commented Apr 6, 2021 •

edited

donho commented Apr 6, 2021 •

edited

mere-human commented Apr 7, 2021 •

edited

mere-human commented Apr 13, 2021

donho left a comment

donho left a comment

mere-human Apr 15, 2021

sasumner commented Apr 16, 2021

mere-human commented Apr 16, 2021

sasumner commented Apr 16, 2021

sasumner commented Apr 17, 2021

mere-human commented Apr 17, 2021

sasumner commented Apr 17, 2021

mere-human commented Apr 17, 2021

sasumner commented Apr 18, 2021

pryrt commented Jun 1, 2021 •

edited

mere-human commented Jun 1, 2021 •

edited

mere-human commented Jun 1, 2021

sasumner commented Jun 1, 2021 •

edited

donho commented Jun 3, 2021

mere-human commented Jun 3, 2021

sasumner commented Jun 3, 2021

Add "Assign file type" checkbox to Save As dialog #9732

Add "Assign file type" checkbox to Save As dialog #9732

Conversation

mere-human commented Apr 6, 2021

mere-human commented Apr 6, 2021 • edited

donho commented Apr 6, 2021 • edited

mere-human commented Apr 7, 2021 • edited

mere-human commented Apr 13, 2021

donho left a comment

Choose a reason for hiding this comment

donho left a comment

Choose a reason for hiding this comment

mere-human Apr 15, 2021

Choose a reason for hiding this comment

sasumner commented Apr 16, 2021

mere-human commented Apr 16, 2021

sasumner commented Apr 16, 2021

sasumner commented Apr 17, 2021

mere-human commented Apr 17, 2021

sasumner commented Apr 17, 2021

mere-human commented Apr 17, 2021

sasumner commented Apr 18, 2021

pryrt commented Jun 1, 2021 • edited

mere-human commented Jun 1, 2021 • edited

mere-human commented Jun 1, 2021

sasumner commented Jun 1, 2021 • edited

donho commented Jun 3, 2021

mere-human commented Jun 3, 2021

sasumner commented Jun 3, 2021

mere-human commented Apr 6, 2021 •

edited

donho commented Apr 6, 2021 •

edited

mere-human commented Apr 7, 2021 •

edited

pryrt commented Jun 1, 2021 •

edited

mere-human commented Jun 1, 2021 •

edited

sasumner commented Jun 1, 2021 •

edited