Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close all tabs in stack with single action #9930

Closed
wants to merge 1 commit into from

Conversation

Uhf7
Copy link
Contributor

@Uhf7 Uhf7 commented May 31, 2021

Implements #8922. Shift-click closes the whole stack now.

I included the "Close" tooltip in localization, but I didn't extend this tooltip yet for the following reason: If the side window is not docked, it has an original Windows title bar. The tooltip for the Close button in this title bar is always "Close", and cannot be modified in any easy way. So, if we extend the tooltip in the docked state only, we have two different tooltips, docked and undocked.

This could be overcome only by drawing an own title bar for the undocked side windows. In this case, the title bars of docked and undocked side windows could made look the same way. But I did not any experiment in this direction right now.

@chcg chcg added the enhancement Proposed enhancements of existing features label May 31, 2021
@donho
Copy link
Member

donho commented Jun 3, 2021

OK, let's keep the current way.
Does "Close" tooltip in localization work in both docked & undocked ways?

@donho donho closed this in f9d6fb9 Jun 3, 2021
@Uhf7
Copy link
Contributor Author

Uhf7 commented Jun 4, 2021

Does "Close" tooltip in localization work in both docked & undocked ways?

Not in the same way. If docked, the localization of Notepad++ works. If undocked, the localization mechanism of Windows works. So it may end up in different tooltips, if both localizations are not synchronous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposed enhancements of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants