-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greatly improve plugin list, including security-related enhancements #154
Conversation
Fix many errors. Add missing homepages. Fix erroneous homepages. Add missing author credits. Simplify descriptions and improve consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to update the pl.x64.json
file.
Fix many errors. Convert links to https when possible. Remove link to possible malware site. Fix broken links. Add missing homepages. Fix erroneous homepages. Fix syntax errors Add missing author credits. Simplify descriptions and improve consistency.
Not forgotten. I do not have time to work on it as well. It's for you or others to update that file with the changes made to the x86 file. |
@Gitoffthelawn , see failing appveyor check for valid json: What I like:
, but I dislike, mixing all into one commit. I'm still uncertain on: I don't like the manipulations on the descriptions apart from formatting stuff like spaces, EOL, uppercase/lowercase as that was mostly written be the original authors of the plugins and I think that shouldn't be modified without their ok (at least from the ones still actively working on their plugins). |
I don't see an error. Do you? I'm happy to fix it if you see it.
You're welcome. I understand your concern, but if I made 7 commits, then people would complain about that. I spent several hours on this as a favor, and I don't have more time to spend.
It doesn't matter to me. All I did was go to the public source code pages and copy pasta'd their names. I'm all for respecting people's privacy, but people intentionally included their names on those public pages or in their code, so I figured it was most likely accidental omissions.
If you have the time, you can ask each one for approval. Many of the descriptions were in broken English and a couple were almost unintelligible. I didn't change the meaning of any of the descriptions; I fixed errors, made them easier to comprehend, and made them easier to translate to other languages. :) |
@Gitoffthelawn Thanks for the contribution. After thinking again about it I came to conclusion that the active maintainers could change it back if they don't like it. I will take care on the merge with the x64 version. |
You're welcome! :) And thank you for the merge with the x64 version. |
Greatly improve plugin list, including security-related enhancements #154 to x64
Fix many errors.
Convert links to https when possible.
Remove link to possible malware site.
Fix broken links.
Add missing homepages.
Fix erroneous homepages.
Fix syntax errors
Add missing author credits.
Simplify descriptions and improve consistency.