Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly improve plugin list, including security-related enhancements #154

Merged
merged 4 commits into from
Jan 4, 2020

Conversation

Gitoffthelawn
Copy link
Contributor

@Gitoffthelawn Gitoffthelawn commented Dec 15, 2019

Fix many errors.
Convert links to https when possible.
Remove link to possible malware site.
Fix broken links.
Add missing homepages.
Fix erroneous homepages.
Fix syntax errors
Add missing author credits.
Simplify descriptions and improve consistency.

Fix many errors.
Add missing homepages.
Fix erroneous homepages.
Add missing author credits.
Simplify descriptions and improve consistency.
Copy link

@MAPJe71 MAPJe71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update the pl.x64.json file.

src/pl.x86.json Outdated Show resolved Hide resolved
Fix many errors.
Convert links to https when possible.
Remove link to possible malware site.
Fix broken links.
Add missing homepages.
Fix erroneous homepages.
Fix syntax errors
Add missing author credits.
Simplify descriptions and improve consistency.
@Gitoffthelawn Gitoffthelawn changed the title Greatly improve plugin list Greatly improve plugin list, including security-related enhancements Dec 15, 2019
@Gitoffthelawn
Copy link
Contributor Author

You forgot to update the pl.x64.json file.

Not forgotten. I do not have time to work on it as well. It's for you or others to update that file with the changes made to the x86 file.

@chcg
Copy link
Contributor

chcg commented Dec 16, 2019

@Gitoffthelawn , see failing appveyor check for valid json:
src/pl.x86.json - Expecting ':' delimiter: line 1305 column 3 (char 77170)

What I like:

Fix many errors.
Convert links to https when possible.
Remove link to possible malware site.
Fix broken links.
Add missing homepages.
Fix erroneous homepages.
Fix syntax errors

, but I dislike, mixing all into one commit.

I'm still uncertain on:
Add missing author credits.
, because most likely the authors didn't add their name at the previous corresponding pluginmanager database for some reason.

I don't like the manipulations on the descriptions apart from formatting stuff like spaces, EOL, uppercase/lowercase as that was mostly written be the original authors of the plugins and I think that shouldn't be modified without their ok (at least from the ones still actively working on their plugins).

@Gitoffthelawn
Copy link
Contributor Author

@Gitoffthelawn , see failing appveyor check for valid json:
src/pl.x86.json - Expecting ':' delimiter: line 1305 column 3 (char 77170)

I don't see an error. Do you? I'm happy to fix it if you see it.

What I like:

Fix many errors.
Convert links to https when possible.
Remove link to possible malware site.
Fix broken links.
Add missing homepages.
Fix erroneous homepages.
Fix syntax errors

, but I dislike, mixing all into one commit.

You're welcome. I understand your concern, but if I made 7 commits, then people would complain about that. I spent several hours on this as a favor, and I don't have more time to spend.

I'm still uncertain on:
Add missing author credits.
, because most likely the authors didn't add their name at the previous corresponding pluginmanager database for some reason.

It doesn't matter to me. All I did was go to the public source code pages and copy pasta'd their names. I'm all for respecting people's privacy, but people intentionally included their names on those public pages or in their code, so I figured it was most likely accidental omissions.

I don't like the manipulations on the descriptions apart from formatting stuff like spaces, EOL, uppercase/lowercase as that was mostly written be the original authors of the plugins and I think that shouldn't be modified without their ok (at least from the ones still actively working on their plugins).

If you have the time, you can ask each one for approval. Many of the descriptions were in broken English and a couple were almost unintelligible. I didn't change the meaning of any of the descriptions; I fixed errors, made them easier to comprehend, and made them easier to translate to other languages. :)

src/pl.x86.json Outdated Show resolved Hide resolved
@chcg chcg added this to the 1.1.5 milestone Jan 4, 2020
@chcg chcg merged commit 2019e9d into notepad-plus-plus:master Jan 4, 2020
@chcg
Copy link
Contributor

chcg commented Jan 4, 2020

@Gitoffthelawn Thanks for the contribution. After thinking again about it I came to conclusion that the active maintainers could change it back if they don't like it. I will take care on the merge with the x64 version.

@Gitoffthelawn
Copy link
Contributor Author

You're welcome! :)

And thank you for the merge with the x64 version.

@Gitoffthelawn Gitoffthelawn deleted the patch-1 branch January 4, 2020 19:58
chcg added a commit that referenced this pull request Jan 6, 2020
Greatly improve plugin list, including security-related enhancements #154
to x64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants