Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set proxyauth to any available to fix corp proxies with windows logins Fix #49 #48

Closed
wants to merge 1 commit into from

Conversation

gwinkless
Copy link

@gwinkless gwinkless commented Sep 9, 2023

Some corporate proxies use windows SSO using NTLM.

libcurl already has support for this baked in, but unfortunately by default the updater only allows BASIC authentication (as per https://curl.se/libcurl/c/CURLOPT_PROXYAUTH.html, the default value is CURLAUTH_BASIC). By setting this option to CURLAUTH_ANY and setting the proxy string in npp to http://:@my.proxy.address/, this Just Works.

Fix #49

@gwinkless gwinkless changed the title set proxyauth to any available to fix corp proxies with windows logins set proxyauth to any available to fix corp proxies with windows logins Fix #49 Oct 20, 2023
@xomx
Copy link

xomx commented Oct 21, 2023

@donho
I cannot test this PR myself but it seems to me ok, because then the WinGUP network connectivity should be more universal and safer:

CURLAUTH_ANY
This is a convenience macro that sets all bits and thus makes libcurl pick any it finds suitable.
libcurl automatically selects the one it finds most secure.

@donho donho self-assigned this Oct 21, 2023
@donho donho added the accept label Nov 22, 2023
@donho donho closed this in 17f2ee0 Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updates fail behind corporate proxies that require NTLM authentication
3 participants