Replace Vec::drain_filter removal of empty pages with Vec::retain
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern versions of Rust nightlies have renamed `Vec::drain_filter` to `Vec::extract_if` and changed the semantics slightly, but we actually don't even need it, because stable Rust has `Vec::retain` and we don't need to do anything with the removed pages.
|
Ah that's useful. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern versions of Rust nightlies have renamed
Vec::drain_filtertoVec::extract_ifand changed the semantics slightly, but we actually don't even need it, because stable Rust hasVec::retainand we don't need to do anything with the removed pages.Benchmark results are within margin of error either way, and it simplifies the code.