Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 0 byte write heap buffer overflow in start_decoder #1553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix 0 byte write heap buffer overflow in start_decoder #1553

wants to merge 1 commit into from

Conversation

JarLob
Copy link

@JarLob JarLob commented Oct 19, 2023

Fixes #1552

@ericoporto
Copy link

This proposed fix is obvious - an early exit solution. Looks good.

@nothings
Copy link
Owner

nothings commented Nov 8, 2023

I'd prefer a check that sanity checks the 'len' field and bails if it's bad.

sezero added a commit to sezero/stb that referenced this pull request Dec 12, 2023
@sezero
stb_vorbis: fix CVE-2023-45675, CVE-2023-45676 and CVE-2023-45677.
65cae52 
Based on the patches by Jaroslav Lobačevski (@JarLob) submitted
to mainstream at: nothings#1554 and
nothings#1555

Also see nothings#1552 and
nothings#1553

GHSL-2023-166/CVE-2023-45676: Multi-byte write heap buffer overflow in start_decoder()
GHSL-2023-167/CVE-2023-45677: Heap buffer out of bounds write in start_decoder()
GHSL-2023-165/CVE-2023-45675: 0 byte write heap buffer overflow in start_decoder()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0 byte write heap buffer overflow in start_decoder (GHSL-2023-165/CVE-2023-45675)
3 participants
@JarLob @ericoporto @nothings