Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockquotes with empty newlines #82

Closed
DSofter opened this issue Dec 1, 2018 · 3 comments
Closed

Blockquotes with empty newlines #82

DSofter opened this issue Dec 1, 2018 · 3 comments
Labels
bug enhancement
Milestone
2.0.1

Comments

@DSofter
Copy link

DSofter commented Dec 1, 2018

Hello!

Here I am again, another issue I found.

When I wanted to show

> line1
>
> line2
>
> line3

What I got is something like this:
image

Instead I want something like this:
image

Is there a way to achieve this?

Thank you!
@noties
Copy link
Owner

noties commented Dec 1, 2018

Hello @DSofter !

Actually markdown that you have used is the correct one to achieve what you want. I have checked at dingus and it renders correctly. It turns out Markwon is not correctly inserting new lines for paragraphs. At least was. I fixed that and pushed fix to the development branch. After travis will have finished the build I will update SNAPSHOT version for you to test

@noties
Copy link
Owner

noties commented Dec 1, 2018

@DSofter done, version 2.0.1 is in SNAPSHOT repository

@noties noties added this to the 2.0.1 milestone Dec 1, 2018
@DSofter
Copy link
Author

DSofter commented Dec 2, 2018

image

Works like a charm!

Thank you so much for always being so responsive!

@noties noties mentioned this issue Dec 3, 2018
Merged
noties added a commit that referenced this issue Dec 10, 2018
@noties
V2.0.1 fixed (#83)
26bfb7f 
* `SpannableMarkdownVisitor` Rename blockQuoteIndent to blockIndent
* Fixed block new lines logic for block quote and paragraph (#82)
* AsyncDrawable fix no dimensions bug (#81)
* Update SpannableTheme to use Px instead of Dimension annotation
* Allow TaskListSpan isDone mutation 
* Updated commonmark-java to 0.12.1
* Add OrderedListItemSpan measure utility method (#78)
* Add SpannableBuilder#getSpans method
* Fix DataUri scheme handler in image-loader (#74)
* Introduced a "copy" builder for SpannableThem
  Thanks @c-b-h 🙌
@noties noties closed this as completed Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
2 participants
@DSofter @noties