Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on the overlay to close the popup #48

Closed
hieuvume opened this issue Feb 28, 2022 · 3 comments
Closed

Click on the overlay to close the popup #48

hieuvume opened this issue Feb 28, 2022 · 3 comments
Assignees
@furcan
Labels
done Done enhancement New feature or request
Milestone
v3.2.5

Comments

@hieuvume
Copy link

In the Report feature, you can add a feature that allows the user to click on the overlay to close the popup.
You can add a boolean prop to turn this feature off or on
@hieuvume hieuvume added the enhancement New feature or request label Feb 28, 2022
@furcan
Copy link
Collaborator

furcan commented Feb 28, 2022

Hi @hieuvume ,

I already thought about using that kind of feature for the background overlay before. And then, I decided to not add this feature.

Background overlay is an option that can be switched off as you can see (backOverlay: true). And maybe another option can be added as well to removing the Report Boxes as you have recommended with a click event.

I will consider this for the next updates.

Thanks.
Furkan.

@furcan furcan added this to the v3.2.5 milestone Feb 28, 2022
@hieuvume
Copy link
Author

hieuvume commented Mar 1, 2022

I'm looking forward to this. Hopefully it will be in the next update soon

furcan added a commit that referenced this issue Mar 6, 2022
@furcan
Version 3.2.5
dfaf93f 
Added: `Notiflix.Report.*` module: `backOverlayClickToClose` option has been added. Default value is `false`. It removes the Report Notification when the background overlay element has been clicked. The existing `backOverlay` option has to be `true` as well. [#48](#48)

Changed: Code Review/Refactor.
@furcan
Copy link
Collaborator

furcan commented Mar 6, 2022

Hi @hieuvume,

v3.2.5 has been released.

https://github.com/notiflix/Notiflix/blob/main/CHANGELOG.md

@furcan furcan closed this as completed Mar 6, 2022
@furcan furcan added the done Done label Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@furcan furcan

Labels
done Done enhancement New feature or request
Projects
Notiflix
Status: Done
Milestone
v3.2.5
Development

No branches or pull requests
2 participants
@furcan @hieuvume