-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filetime pin is outdated #202
Comments
We can't. Filetime has pushed their minimum rustc version to 1.32 as of 0.2.6, while notify guarantees to be compatible down to 1.26.1 without a major version bump. |
See #201 |
Hm, pin dependencies in Cargo.toml are usually not a good idea. If a project depends on notify 0.4 and on some other library A that has Note that you don't have to pin That is, clients of notify will still be able to use notify with old Rust, but it's the client responsibility to make sure they have The practical problem here is building the crate on CI: without lockfile, Cargo will pull the newest filetime, and it will break CI for old Rust. The work around here is to actually use a lockfile when testing with older rusts. See how |
I've noticed I can't update to the latest tar release because it depends on filetime 0.2.6, while notify has an explicit pin on filetime 0.2.5, preventing the update.
Please consider pushing an update.
The text was updated successfully, but these errors were encountered: