implement passive debouncer without blocking #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpr03
force-pushed
the
debouncer_passive
branch
3 times, most recently
from
c1feee8
to
1ce7060
Compare
|
cc @kchibisov |
0xpr03
force-pushed
the
debouncer_passive
branch
from
1ce7060
to
1cb521d
Compare
0xpr03
commented
Jan 28, 2023
notify-debouncer-mini/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| // // drain events channel |
There was a problem hiding this comment.
I'm not sure if we want this, it certainly allows us to receive rapid fired events.
There was a problem hiding this comment.
I don't think that it'll provide any value? The "rapid fire" events will be handled by recv_timeout anyway just fine.
0xpr03
force-pushed
the
debouncer_passive
branch
11 times, most recently
from
551dc86
to
0de9a72
Compare
kchibisov
reviewed
Jan 29, 2023
notify-debouncer-mini/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| // // drain events channel |
There was a problem hiding this comment.
I don't think that it'll provide any value? The "rapid fire" events will be handled by recv_timeout anyway just fine.
0xpr03
force-pushed
the
debouncer_passive
branch
3 times, most recently
from
5051444
to
bacc7c5
Compare
Merged
0xpr03
force-pushed
the
debouncer_passive
branch
2 times, most recently
from
1febce8
to
08e685c
Compare
0xpr03
force-pushed
the
debouncer_passive
branch
5 times, most recently
from
ca4b2c3
to
9dd1e8c
Compare
Switches from active polling to an event loop that can fully sleep. Also overhauls the configuration with a builder. Bumps version to 0.4
0xpr03
force-pushed
the
debouncer_passive
branch
from
9dd1e8c
to
96ea260
Compare
|
CC @dfaust because we'll have to retrofit this for the debouncer-full too (especially the semver breaking config change, to future proof additional config values) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove active polling and introduce a passive waiting method that can also shutdown everything.
This fixes #466