Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure prerelease npm still allow npx usage #239

Merged
merged 1 commit into from Feb 9, 2019
Merged

Ensure prerelease npm still allow npx usage #239

merged 1 commit into from Feb 9, 2019

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Jan 11, 2019

Using VersionReq::matches will (intentionally) not match prerelease versions. Instead you must compare via >=.

Fixes #238

charlespierce
charlespierce approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@charlespierce charlespierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick on the comment, but LGTM!

crates/notion-core/src/tool.rs Outdated Show resolved Hide resolved
@rwjblue
Ensure prerelease npm still allow npx usage
188e357 
Using `VersionReq::matches` will (intentionally) not match prerelease
versions. Instead you must compare via `>=`.
dherman
dherman approved these changes Jan 11, 2019
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mikrostew
mikrostew reviewed Jan 11, 2019
View reviewed changes
Copy link
Contributor

@mikrostew mikrostew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Ideally I would like to see a test or two added for little bugs like this, to prevent it happening again.

@dherman dherman merged commit 188e357 into volta-cli:master Feb 9, 2019
@rwjblue rwjblue deleted the fixup-npx-check-logic branch February 9, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikrostew mikrostew mikrostew left review comments

@dherman dherman dherman approved these changes

@charlespierce charlespierce charlespierce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rwjblue @mikrostew @dherman @charlespierce