Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Minimal Notion Icons" set #2

Merged
merged 3 commits into from
Nov 18, 2020

Conversation

fabiosangregorio
Copy link
Contributor

This PR adds two "Minimal Notion Icons" sets of 200+ icons by an unknown author (link to the source here):

  • Colored
  • Monochromatic

These sets are licensed under the Creative Commons License (as stated in the page).

Please note that the sets path in icons.json is currently pointing to my fork. Let me know if I should remove the corresponding lines.

@dragonwocky
Copy link
Member

Nice - please add the Creative Commons license into the folders with the images before merge.

@fabiosangregorio
Copy link
Contributor Author

Of course, I'll do this this morning.
As in the first comment, the sets path in icons.json is currently pointing to my fork. Please let me know if I should remove the corresponding lines.

@dragonwocky
Copy link
Member

Ah, missed that before. Yeah, it's better if things are served from the main repo rather than a fork.

Add CC-SA 4.0 license to MNIC adn MNIM.
Remove sourceUrl pointing to the PR fork.
@fabiosangregorio
Copy link
Contributor Author

I added the license files and removed the sourceUrls from icons.json. This PR should be ready to be merged now.

@dragonwocky dragonwocky merged commit 6c8c757 into notion-enhancer:main Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants