Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdk-46 evmos test #70

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Fix sdk-46 evmos test #70

merged 2 commits into from
Jul 18, 2022

Conversation

GNaD13
Copy link

@GNaD13 GNaD13 commented Jul 18, 2022

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@@ -128,7 +128,7 @@ func (k Keeper) rewardAllocations(
}

// allocation for the contract is the amount escrowed * the allocation %
coinAllocated := denomBalances[al.Denom].Mul(al.Amount)
coinAllocated := denomBalances[al.Denom].Mul(al.Amount.RoundInt())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Dec*Dec then roundInt

@nghuyenthevinh2000 nghuyenthevinh2000 merged commit eca42b0 into sdk-46 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants